Skip to content

fix(controller): cap answers rendered into the server-side page #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
culfin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(controller): cap answers rendered into the server-side page #1574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion internal/controller/template_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,17 @@ import (
"github.com/segmentfault/pacman/log"
)

// maxTemplateAnswerPageSize caps how many answers are rendered into the
// server-side page. The template shows every answer it is given and has no
// pagination, so this value is also the number of answers a crawler sees.
//
// It exists because the previous value of 999 made long questions unusable:
// the server fetches the answers, then the comments for every one of them,
// and the browser has to parse and hydrate the result. On a question with
// 999 answers that took 2.6s on the server and 23.5s until the first answer
// was visible, against 0.2s for an ordinary question.
const maxTemplateAnswerPageSize = 100

var SiteUrl = ""

type TemplateController struct {
Expand Down Expand Up @@ -345,7 +356,7 @@ func (tc *TemplateController) QuestionInfo(ctx *gin.Context) {
QuestionID: id,
Order: "",
Page: 1,
PageSize: 999,
PageSize: maxTemplateAnswerPageSize,
UserID: "",
}
answers, answerCount, err := tc.templateRenderController.AnswerList(ctx, answerReq)
Expand Down