[AMORO-4220] [Improvement] Support BETWEEN and reversed comparison SQL filters in ExpressionUtil.#4221
Open
slfan1989 wants to merge 1 commit into
Open
[AMORO-4220] [Improvement] Support BETWEEN and reversed comparison SQL filters in ExpressionUtil.#4221slfan1989 wants to merge 1 commit into
slfan1989 wants to merge 1 commit into
Conversation
…L filters in ExpressionUtil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #4220.
ExpressionUtil.convertSqlFilterToIcebergExpression()currently supports basic SQL filters only when the table column is on the left side of a comparison, such ascolumn_a > 1.However, some valid SQL filter forms are not supported yet:
column_a BETWEEN 1 AND 10column_a NOT BETWEEN 1 AND 101 < column_a1 <= column_aThese expressions are common in SQL predicates. Supporting them makes SQL filter conversion more complete and improves compatibility with user-provided filter conditions.
Brief change log
BETWEENandNOT BETWEENinExpressionUtil.1 < column_a->column_a > 11 >= column_a->column_a <= 1TestExpressionUtilfor:BETWEENNOT BETWEEN>,>=,<,<=,=, and!=comparisonsHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation