Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3323]Exclude hadoop-client-api dependency #3324

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

zhoujinsong
Copy link
Contributor

@zhoujinsong zhoujinsong commented Nov 5, 2024

Why are the changes needed?

Close #3323.

Brief change log

  • Exclude hadoop-client-api dependency to avoid class conflict with hadoop-common

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@klion26
Copy link
Member

klion26 commented Nov 5, 2024

Thanks for the contribution, LGTM

After removing the hadoop-client-api-3.3.4.jar from lib dir, can upload the file successfully now.

@klion26
Copy link
Member

klion26 commented Nov 5, 2024

checked that there is no hadoop-client-api-3.3.4.jar after apply this patch on 0.7.x

image

Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoujinsong zhoujinsong merged commit b6a3549 into apache:master Nov 11, 2024
4 checks passed
@zhoujinsong zhoujinsong deleted the fix-class-conflict branch November 11, 2024 02:48
zhoujinsong added a commit that referenced this pull request Nov 11, 2024
Exclude hadoop-client-api dependency

(cherry picked from commit b6a3549)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants