Skip to content

[Bug]: The commit.retry.num-retries configuration does not take effect when configured on the catalog. #3384

Open
@lintingbin

Description

@lintingbin

What happened?

In our production environment, we often encounter commit failure errors in Amoro. I tried to change the commit.retry.num-retries configuration on the catalog in Amoro to 30, but found that it didn't take effect. After troubleshooting, I discovered that during Amoro commit, the commitSimpleTransaction function in the org.apache.iceberg.BaseTransaction class is executed. This function retrieves the commit.retry.num-retries parameter directly from the metadata file's content, so the configuration set on the catalog does not take effect.

Affects Versions

0.7.1

What table formats are you seeing the problem on?

Iceberg

What engines are you seeing the problem on?

AMS

How to reproduce

No response

Relevant log output

No response

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

  • I agree to follow this project's Code of Conduct

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions