-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[AMBARI-23275] - Upgrade maven dependency for jdeb and for rpm-maven-plugin #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Refer to this link for build results (access rights to CI server needed): |
@@ -207,7 +207,7 @@ | |||
<plugin> | |||
<groupId>org.vafer</groupId> | |||
<artifactId>jdeb</artifactId> | |||
<version>1.4</version> | |||
<version>1.6 </version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove extra whitespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks for the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can inheritance be used here?
Refer to this link for build results (access rights to CI server needed): |
@oleewere Can you please review, too? Thanks. |
@adoroszlai - Removed redundancy of defining version. Please review. |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can someone help in getting it merged. |
This reverts commit f444580.
This reverts commit f444580.
What changes were proposed in this pull request?
Upgraded maven dependency for jdeb and rpm-maven-plugin. Some configurations are not picked because of outdated dependency. Also the spec file creation timr has improved in latest plugins
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.