Skip to content

Conversation

mnpoonia
Copy link
Contributor

What changes were proposed in this pull request?

Upgraded maven dependency for jdeb and rpm-maven-plugin. Some configurations are not picked because of outdated dependency. Also the spec file creation timr has improved in latest plugins

How was this patch tested?

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Ambari Contributing Guide before opening a pull request.

@asfgit
Copy link

asfgit commented Mar 18, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1224/
Test PASSed.

@@ -207,7 +207,7 @@
<plugin>
<groupId>org.vafer</groupId>
<artifactId>jdeb</artifactId>
<version>1.4</version>
<version>1.6 </version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove extra whitespace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for the review

Copy link
Contributor

@rlevas rlevas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can inheritance be used here?

@asfgit
Copy link

asfgit commented Mar 19, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1226/
Test PASSed.

@adoroszlai
Copy link
Contributor

@oleewere Can you please review, too? Thanks.

@mnpoonia
Copy link
Contributor Author

@adoroszlai - Removed redundancy of defining version. Please review.

@asfgit
Copy link

asfgit commented Mar 24, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1329/
Test FAILed.
Test FAILured.

@asfgit
Copy link

asfgit commented Mar 24, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1331/
Test FAILed.
Test FAILured.

@asfgit
Copy link

asfgit commented Mar 24, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1332/
Test FAILed.
Test FAILured.

Copy link
Contributor

@oleewere oleewere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnpoonia
Copy link
Contributor Author

Can someone help in getting it merged.

@adoroszlai adoroszlai merged commit f444580 into apache:trunk Mar 27, 2018
avijayanhwx pushed a commit to avijayanhwx/ambari that referenced this pull request Mar 28, 2018
avijayanhwx pushed a commit that referenced this pull request Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants