Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for databricks spark python and submit tasks. #8846

Merged
merged 1 commit into from
May 22, 2020

Conversation

siddartha-ravichandran
Copy link
Contributor

@siddartha-ravichandran siddartha-ravichandran commented May 12, 2020


The Databricks Jobs API, which exposes the Runs Submit API, documented here: https://docs.databricks.com/dev-tools/api/latest/jobs.html#runs-submit, supports the following 4 tasks: spark_jar_task, notebook_task, spark_python_task and spark_submit_task. The databricks operator which exposes this functionality however did not support the latter 2 (spark_python_task and spark_submit_task). This PR adds support for these 2 tasks.

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

@boring-cyborg
Copy link

boring-cyborg bot commented May 12, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://apache-airflow-slack.herokuapp.com/

@mik-laj mik-laj merged commit f107338 into apache:master May 22, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented May 22, 2020

Awesome work, congrats on your first merged pull request!

@siddartha-ravichandran siddartha-ravichandran deleted the databricks-operators branch May 22, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants