Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change provider:GCP label to provider:Google #8697

Merged
merged 1 commit into from
May 4, 2020

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented May 4, 2020

It seems to me that it has a lot in common. Most GCP experts can also use the API of other Google services. I am also sad because the changes in the base hook have no label.

We need to change name of the label in Github before merging this change.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label May 4, 2020
@mik-laj mik-laj requested a review from kaxil May 4, 2020 01:17
@mik-laj mik-laj changed the title Changea provider:GCP to provider:Google Change provider:GCP label to provider:Google May 4, 2020
@kaxil kaxil merged commit 5ddc458 into apache:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants