-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for pre-2.0 style hostname_callable config value #8637
Conversation
…old pattern in the val. Updates 'hostname_callable'.
@jhtimmins could you please explain a bit more what this PR does and what bug it addresses? |
@dimberman This addresses an incompatibility between versions 1.10 and 2. For the This is a problem if you already have an airflow.cfg file (or unittest.cfg) from < 2.0, as airflow will continue to use the out-of-date values and throw an error. This branch does the following:
|
This lets us pull the change back in to 1.10.x, so that by the time 2.0 is around people will have had time and notice to update, without reading (the now quite long) UPDATING.md. Nice |
(Don't merge this yet, Github Actions haven't run yet) |
Depends on #8463. @dimberman mind adding that to the description? |
…old pattern in the val. Updates 'hostname_callable'.
…mins/airflow into add-deprecated-env-warning
This lets us pull the change back in to 1.10.x, so that by the time 2.0 is around people will have had time and notice to update, without reading (the now quite long) UPDATING.md.
Depends on #8463
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.