Housekeeping of auth backend & Update Security doc #8071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- All authentication backends in `airflow/contrib/auth` are base on the `user` model which has already been removed earlier (apache#4577 (comment)) - Security related documentation is out-dated, especially the LDAP and OAuth integration sections. It still directs user to the configuration of "old" web UI which has already been removed in master branch.
|
Hi @kaxil @potiuk @zhongjiajie , this is the change I mentioned in our earlier discussion #4577 (comment) . I will raise another PR to address similar issue (out-dated documentation) for 1-10-x branch. |
|
Is the code really out-dated :)? I did not realise that :) |
|
@potiuk It will be great if you can help take another further look and confirm. The main reasoning is all of the |
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jun 20, 2020
apache#8071 removed Auth Backend but didn't remove some functions used by those method.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
airflow/contrib/authare base on theusermodel which has already been removed earlier ([AIRFLOW-3761] Decommission User & Chart models & Update doc accordingly #4577)Issue link: WILL BE INSERTED BY boring-cyborg
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.