Fix only_new clear missing new tasks after a 'run on latest version' clear - #71687
Open
pulaksaha143 wants to merge 1 commit into
Open
Fix only_new clear missing new tasks after a 'run on latest version' clear#71687pulaksaha143 wants to merge 1 commit into
only_new clear missing new tasks after a 'run on latest version' clear#71687pulaksaha143 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #71455.
Problem
When a user clears a DagRun with
run_on_latest_version=True, thecreated_dag_version_idcolumn is updated to the latest version. Later, if the user performs a clear withonly_new=True, the_get_new_task_idsfunction diffs the latest DAG's task IDs against the task IDs from the version referenced bycreated_dag_version_id. Because this pointer has mutated, it incorrectly detects an empty diff and silently skips creating actual new tasks.Solution
Instead of relying on the mutable
created_dag_version_id, we now directly query the database for the actualTaskInstancerows associated with theDagRun. We diff these existing task IDs against the latest DAG's task IDs to accurately inject genuinely new tasks.Also includes an automated test asserting correct behavior when
created_dag_version_idhas been updated.