Fix DAG processor detecting non-zip archives as DAG bundles - #71686
Open
pulaksaha143 wants to merge 1 commit into
Open
Fix DAG processor detecting non-zip archives as DAG bundles#71686pulaksaha143 wants to merge 1 commit into
pulaksaha143 wants to merge 1 commit into
Conversation
Fixes apache#71125 Previously, `find_dag_file_paths` used `zipfile.is_zipfile()` to sniff if a file could be a DAG bundle. Since the PK-ZIP format underpins many common file types (such as `.jar`, `.docx`, `.pptx`, `.xlsx`), the DAG processor would waste time opening and scanning these irrelevant files if they were placed in the DAGs folder. This update enforces that a file must end in `.zip` before it is considered a DAG bundle, eliminating wasted CPU cycles and log noise for deployments that store supporting zip-format files alongside their DAGs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71125
Description
Previously,
find_dag_file_pathsusedzipfile.is_zipfile()to sniff if a file could be a DAG bundle. Since the PK-ZIP format underpins many common file types (such as.jar,.docx,.pptx,.xlsx), the DAG processor would waste time opening and scanning these irrelevant files if they were placed in the DAGs folder.This update enforces that a file must end in
.zipbefore it is considered a DAG bundle, eliminating wasted CPU cycles and log noise for deployments that store supporting zip-format files alongside their DAGs.Testing
test_find_dag_file_paths_ignores_non_zip_archivesintest_file.pywhich mocks the presence of.jarand.docxfiles, ensuring they are ignored.