Drop provider dependency from airflow-core secrets backend tests - #71677
Draft
rjgoyln wants to merge 1 commit into
Draft
Drop provider dependency from airflow-core secrets backend tests#71677rjgoyln wants to merge 1 commit into
rjgoyln wants to merge 1 commit into
Conversation
These tests cover how core loads and configures a custom secrets backend, not how any particular backend behaves. Pinning them to the amazon and hashicorp providers made a core-only environment unable to run them, and kept them skipped whenever the full provider set is not installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The secrets tests in
test_secrets.pyandtest_configuration.pyreach for the amazon systems-manager and hashicorp Vault backends purely as stand-ins for "a custom secrets backend". Nothing there asserts anything about either one — the subject is core's own plumbing: how a backend is discovered, howbackend_kwargsand the per-keyBACKEND_KWARG__env vars reach its constructor, and what happens when it returns nothing or fails.That stand-in is what puts these tests out of reach of a core-only environment, and why most of them sat behind
skip_if_force_lowest_dependencies_markerand never ran in the lowest-dependency job. The two Vault tests were worse off still: hashicorp is not inairflow-core's dev group, so a scoped sync already failed them.Coverage is unchanged, down to an explicit JSON
nullreaching the instance; the connection-error path now raises on purpose rather than relying on a mis-shapedhvacmock to fail somewhere inside Vault.First slice of #71641 — cncf.kubernetes, celery, git, fab and pandas follow, and the dev-group entries in
airflow-core/pyproject.tomlcome out once nothing needs them.Tests
Both files pass in a full workspace. In an environment built with
uv sync --project airflow-coreminus the six dev-group providers, the amazon and hashicorp failures are gone; the eight that remain are the celery provider-config tests a later slice covers.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines