Skip to content

Refactor AdvancedSearchToggle and SearchBar components for improved clarity and functionality - #71470

Merged
ryanahamilton merged 1 commit into
apache:mainfrom
astronomer:AdvancedSearchToggle_visual_cleanup
Aug 12, 2026
Merged

Refactor AdvancedSearchToggle and SearchBar components for improved clarity and functionality#71470
ryanahamilton merged 1 commit into
apache:mainfrom
astronomer:AdvancedSearchToggle_visual_cleanup

Conversation

@ryanahamilton

@ryanahamilton ryanahamilton commented Aug 11, 2026

Copy link
Copy Markdown
Contributor
  • Visually simplified the Searchbar component without removing any functionality.
    • Moved the AdvancedSearchToggle inside the search box container to make it obvious that it is directly tied to the functionality of the search before hovering to reveal the tooltip
    • Moved the keyboard shortcut to the placeholder text. The Kbd component stands out too much visually.
  • Gave the "clear search" icon button a tooltip
  • Simplified component code with a single return
  • Searchbar tests continue to pass

Before:

Zight Recording 2026-08-11 at 05 51 47 PM

After:

Zight Recording 2026-08-11 at 05 52 23 PM
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Aug 11, 2026
@ryanahamilton
ryanahamilton marked this pull request as ready for review August 12, 2026 13:49
@bbovenzi bbovenzi added this to the Airflow 3.3.2 milestone Aug 12, 2026
@bbovenzi bbovenzi added the backport-to-v3-3-test Backport to v3-3-test label Aug 12, 2026
@ryanahamilton
ryanahamilton merged commit a23f773 into apache:main Aug 12, 2026
123 of 124 checks passed
@ryanahamilton
ryanahamilton deleted the AdvancedSearchToggle_visual_cleanup branch August 12, 2026 14:32
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-3-test PR Link

github-actions Bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 12, 2026
…r improved clarity and functionality (apache#71470)

(cherry picked from commit a23f773)

Co-authored-by: Ryan Hamilton <ryan@ryanahamilton.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 12, 2026
…r improved clarity and functionality (apache#71470)

(cherry picked from commit a23f773)

Co-authored-by: Ryan Hamilton <ryan@ryanahamilton.com>
bbovenzi pushed a commit that referenced this pull request Aug 12, 2026
…r improved clarity and functionality (#71470) (#71501)

(cherry picked from commit a23f773)

Co-authored-by: Ryan Hamilton <ryan@ryanahamilton.com>
stephen-bracken pushed a commit to stephen-bracken/airflow that referenced this pull request Aug 12, 2026
vatsrahul1001 pushed a commit that referenced this pull request Aug 13, 2026
…r improved clarity and functionality (#71470) (#71501)

(cherry picked from commit a23f773)

Co-authored-by: Ryan Hamilton <ryan@ryanahamilton.com>
dabla pushed a commit to dabla/airflow that referenced this pull request Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-3-test Backport to v3-3-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants