Skip to content

Fix airflow-ctl mypy static check on the 0.1 branch - #71096

Merged
Lee-W merged 1 commit into
apache:airflow-ctl/v0-1-testfrom
astronomer:ctl-v0-1-fix-mypy-static-check
Aug 5, 2026
Merged

Fix airflow-ctl mypy static check on the 0.1 branch#71096
Lee-W merged 1 commit into
apache:airflow-ctl/v0-1-testfrom
astronomer:ctl-v0-1-fix-mypy-static-check

Conversation

@Lee-W

@Lee-W Lee-W commented Aug 4, 2026

Copy link
Copy Markdown
Member

The same test-to-stable sync (#67294) repointed the mypy-airflow-ctl hook at ../scripts/ci/prek/run_mypy_full_dist_local_venv_or_breeze_in_ci.py, which only exists on main. On this branch prek dies before mypy ever runs:

error: Failed to run hook `mypy-airflow-ctl`
  caused by: Run command `python hook` failed
  caused by: No such file or directory (os error 2)

Point it back at mypy_local_folder.py, which is what airflow-core, task-sdk, devel-common and dev/scripts all use on this branch.

Split out of #70724 so that PR stays workflow-only.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Opus 5

Generated-by: Claude Opus 5 following the guidelines

The same test-to-stable sync (apache#67294) repointed the mypy-airflow-ctl hook
at ../scripts/ci/prek/run_mypy_full_dist_local_venv_or_breeze_in_ci.py,
which only exists on main. On this branch prek dies before mypy runs:

    error: Failed to run hook `mypy-airflow-ctl`
      caused by: Run command `python hook` failed
      caused by: No such file or directory (os error 2)

Point it back at mypy_local_folder.py, which is what airflow-core,
task-sdk, devel-common and dev/scripts all use on this branch.
@Lee-W
Lee-W marked this pull request as ready for review August 5, 2026 08:43

@jason810496 jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Perhaps we can update the airflow/.github/boring-cyborg.yml as follow-up?

# This should be copy of the "area:dev-tools" above minus contributing docs and some files that should
# only make sense in main - it should be updated when we switch maintenance branch.
# Scoped to PRs targeting `main` only — a PR opened directly against v3-3-test
# does not need a backport-to-v3-3-test label.
backport-to-v3-3-test:
paths:
- scripts/**/*
- dev/**/*
- .github/**/*
- Dockerfile.ci
- yamllint-config.yml
- .dockerignore
- .hadolint.yaml
- .pre-commit-config.yaml
- .rat-excludes
targetBranchFilter:
- ^main$
# Apply to PRs touching airflow-ctl code so the release manager notices when a
# fix should land on the airflow-ctl/v0-1-test maintenance branch.
# Scoped to PRs targeting `main` only.
backport-to-airflow-ctl/v0-1-test:
paths:
- airflow-ctl/**/*
targetBranchFilter:
- ^main$

@Lee-W

Lee-W commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

yep, sound good, will create a seprate PR for that

@Lee-W
Lee-W merged commit 1938a00 into apache:airflow-ctl/v0-1-test Aug 5, 2026
2 checks passed
@Lee-W
Lee-W deleted the ctl-v0-1-fix-mypy-static-check branch August 5, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants