Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Airflow-6110] [AIP-21] Rename GCP natural language operators #6968

Conversation

michalslowikowski00
Copy link
Contributor

PR contains changes regarding GCP natural language operators:

  • renamed classes: CloudLanguageAnalyzeEntitiesOperator, CloudLanguageAnalyzeEntitySentimentOperator, CloudLanguageAnalyzeSentimentOperator, CloudLanguageClassifyTextOperator

  • fixed testes

  • updated UPDATING.md

  • Description above provides context of the change

  • Commit message contains [AIRFLOW-6110] or [AIRFLOW-XXXX] for document-only changes

  • Unit tests coverage for changes (not needed for documentation changes)

  • Commits follow "How to write a good git commit message"

  • Relevant documentation is updated including usage instructions.

  • I will engage committers as explained in Contribution Workflow Example.
    In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
    In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
    In case of backwards incompatible changes please leave a note in UPDATING.md.
    Read the Pull Request Guidelines for more information.

@michalslowikowski00 michalslowikowski00 force-pushed the AIRFLOW-6110-Rename-natural_language-service branch from fce1866 to 94ffaee Compare December 30, 2019 15:59
@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Dec 30, 2019
@michalslowikowski00 michalslowikowski00 force-pushed the AIRFLOW-6110-Rename-natural_language-service branch from 94ffaee to cc9cb14 Compare December 31, 2019 05:18
@codecov-io
Copy link

codecov-io commented Dec 31, 2019

Codecov Report

Merging #6968 into master will decrease coverage by 0.29%.
The diff coverage is 84%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #6968     +/-   ##
=========================================
- Coverage   84.81%   84.52%   -0.3%     
=========================================
  Files         679      679             
  Lines       38489    38505     +16     
=========================================
- Hits        32646    32547     -99     
- Misses       5843     5958    +115
Impacted Files Coverage Δ
...gle/cloud/example_dags/example_natural_language.py 0% <0%> (ø) ⬆️
...oviders/google/cloud/operators/natural_language.py 100% <100%> (ø) ⬆️
...contrib/operators/gcp_natural_language_operator.py 100% <100%> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️
airflow/jobs/backfill_job.py 90.43% <0%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd319e8...cc9cb14. Read the comment docs.

@michalslowikowski00 michalslowikowski00 marked this pull request as ready for review December 31, 2019 09:01
@turbaszek turbaszek merged commit 95087af into apache:master Dec 31, 2019
@michalslowikowski00 michalslowikowski00 deleted the AIRFLOW-6110-Rename-natural_language-service branch January 26, 2020 08:35
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants