Go SDK: ADRs for bundle packing and coordinator-protocol runtime#67153
Draft
jason810496 wants to merge 5 commits into
Draft
Go SDK: ADRs for bundle packing and coordinator-protocol runtime#67153jason810496 wants to merge 5 commits into
jason810496 wants to merge 5 commits into
Conversation
…ocumentation and codebase
…etadata and source
This was referenced May 19, 2026
Member
Author
|
The CI failure should be fixed after the dependent PRs get merged and rebase. |
jason810496
commented
May 19, 2026
| 2. **Extend `bundlev1server.Serve` with `--dump-bundle-spec`.** The | ||
| flag prints a JSON document of the form: | ||
|
|
||
| ```json |
Member
Author
There was a problem hiding this comment.
We could define the JSON schema of the airflow-metadata.yaml format either in this PR or the next one.
It was added in 478edab#diff-82337e6c6586f2c271a1457ae2f45acf563aa7b75ce82a78f163cf78690c91b4
| 3. **Bundle authors register the packer in their own `go.mod`:** | ||
|
|
||
| ``` | ||
| tool github.com/apache/airflow/go-sdk/cmd/airflow-go-pack |
Member
Author
There was a problem hiding this comment.
The release management issue is tracked in #66938
| ### Footer layout | ||
|
|
||
| A bundle file is laid out as: | ||
|
|
Member
Author
There was a problem hiding this comment.
The user-facing doc regarding the executable bundle spec was added in 478edab#diff-0f63500bac12820edd728da72331356b8546a8d571ed949df07a96e1085b835d
| +---------------------------------+ <- EOF | ||
| ``` | ||
|
|
||
| `AFBNDL01` is `0x41 0x46 0x42 0x4E 0x44 0x4C 0x30 0x31`. The two |
Member
Author
There was a problem hiding this comment.
The AFBNDL01 magic represents Airflow BuNDLe version 01, we could change it to anything anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Capture the design decisions behind the next slice of Go SDK work — how
bundles are packed, which packer mechanism we adopt, how the bundle
binary speaks the coordinator protocol, and how the artefact is
shipped. These ADRs are the contract the follow-up implementation PRs
build against, so they need to land first (and stand on their own as
documentation).
What
SDK and pick the option set we'll deliver (standalone packer + Go
1.24
tooldirective + standardised--dump-bundle-spec).tooldirective as the deliverymechanism for the bundle packer; rationale for not vendoring a CLI
or shipping a separate distribution.
msgpack-over-IPC path alongside the existing go-plugin/Edge-Worker
path — so the same binary can run under both task execution models.
with footer-embedded source and metadata; supersedes the ZIP-archive
shape from ADRs 0001/0002 while keeping the same packer mechanism.
Next
Was generative AI tooling used to co-author this PR?