[v3-2-test] fix(DagCalendarTab): improve background color retrieval and loading overlay handling (#64189)#66860
Merged
Merged
Conversation
…verlay handling (#64189) * fix(DagCalendarTab): improve background color retrieval and loading overlay handling * fix(DagCalendarTab): update loading overlay and calendar cell visibility checks * fix(DagCalendarTab): improve background color retrieval and loading overlay handling * fix(DagCalendarTab): update loading overlay and calendar cell visibility checks * refactor: update visibility checks in DagCalendarTab * remove redundant visibility checks in DagCalendarTab * removed unrelated change and attempted to resolve merge conflict markers * Update airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * updated getActiveCellColors to use getComputedStyle to properly return rendered color of an element * simplify child element color retrieval and improve readability * changed file mode --------- Co-authored-by: Yeonguk Choo <choo121600@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit a02fbaa)
1 task
choo121600
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #64189 for the Airflow 3.2.2 patch release.
Conflict resolution
One conflict in
airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts::navigateToCalendar. The PR side used athis.safeGoto(...)helper plusexpect(...).toBeVisible(), whilev3-2-test'sBasePagedoes not exportsafeGoto. Kept thev3-2-teststyle (this.page.goto(...)+waitFor({ state: "visible" })) to avoid introducing a runtime reference error. The remainder of #64189 (background-colour retrieval logic, loading-overlay handling, visibility checks) applied cleanly.