Skip to content

Fix asset graph view leaking DAGs outside the user's permissions#65273

Merged
Lee-W merged 1 commit into
apache:mainfrom
potiuk:fix/asset-graph-dag-access-control
Apr 15, 2026
Merged

Fix asset graph view leaking DAGs outside the user's permissions#65273
Lee-W merged 1 commit into
apache:mainfrom
potiuk:fix/asset-graph-dag-access-control

Conversation

@potiuk
Copy link
Copy Markdown
Member

@potiuk potiuk commented Apr 15, 2026

The data-dependency graph endpoint (/ui/dependencies?node_id=asset:<id>&dependency_type=data)
always returned the requested asset node, even when the user had no lineage connection
to it through any readable DAG. A user with read access to even a single DAG could
browse the asset graph page for any asset in the system and learn its name and any
topology fragments reachable through their readable DAGs.

The asset is now hidden entirely (HTTP 404) unless the user has read access to at
least one DAG that produces, consumes, or is scheduled by it. Tasks from non-readable
DAGs continue to be filtered out from the returned graph.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Claude Code - Opus 4.6] following the guidelines

The data-dependency graph endpoint always returned the requested asset
node, even when the user had no lineage connection to it through any
readable DAG. A user with read access to a single DAG could browse
/assets/<id> for any asset in the system and learn its name and any
topology fragments reachable through their readable DAGs.

The asset is now hidden entirely (404) unless the user has read access
to at least one DAG that produces, consumes, or is scheduled by it.
@boring-cyborg boring-cyborg Bot added the area:API Airflow's REST/HTTP API label Apr 15, 2026
@potiuk potiuk added the backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch label Apr 15, 2026
@potiuk potiuk added this to the Airflow 3.2.1 milestone Apr 15, 2026
@vatsrahul1001
Copy link
Copy Markdown
Contributor

LGTM!,
@Lee-W can your review this?

@Lee-W Lee-W merged commit cf3452d into apache:main Apr 15, 2026
141 checks passed
github-actions Bot pushed a commit that referenced this pull request Apr 15, 2026
…issions (#65273)

(cherry picked from commit cf3452d)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@github-actions
Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-2-test PR Link

github-actions Bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Apr 15, 2026
…issions (apache#65273)

(cherry picked from commit cf3452d)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Lee-W pushed a commit that referenced this pull request Apr 15, 2026
…issions (#65273) (#65280)

(cherry picked from commit cf3452d)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
…issions (#65273) (#65280)

(cherry picked from commit cf3452d)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
…issions (#65273) (#65280)

(cherry picked from commit cf3452d)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
…issions (#65273) (#65280)

(cherry picked from commit cf3452d)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
…issions (#65273) (#65280)

(cherry picked from commit cf3452d)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
karenbraganz pushed a commit to karenbraganz/airflow that referenced this pull request Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants