Fix LocalExecutor crash on non-picklable exceptions (e.g. httpx.HTTPStatusError)#64485
Open
Pranaykarvi wants to merge 1 commit intoapache:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64476
When LocalExecutor runs a task in a subprocess, exceptions are passed back via multiprocessing.Queue using pickle. Some exceptions like httpx.HTTPStatusError are not pickle-safe, causing:
This crashes the scheduler loop and takes down the entire scheduler pod.
Root Cause
Raw exception objects were placed directly onto the result queue:
Fix
Wrap the exception in a plain Exception before queuing:
Applied to both ExecuteTask and ExecuteCallback branches.
Impact