Closed
Conversation
tirkarthi
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
tirkarthi
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl,
kaxil and
potiuk
as code owners
Contributor
|
My only hesitation is installing 8.0.0 instead of waiting for 8.0.1 at least |
Contributor
Author
|
Agreed @bbovenzi. I will close this but keep issue open as a reminder. I will wait for the first set of bug fix releases though there is no timeline in vitejs github. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to Vite 8 which uses rolldown and has better performance. It reduces the build time (
pnpm build) by at least 2x. PR generated bypnpm install vite@8command. Verified thatpnpm devandpnpm buildworks.Upgraded vitest for vite 8 compatibility
vitest-dev/vitest#9587
Upgrade node required version to 22 for rolldown
https://github.com/rolldown/rolldown/blob/b15ec6078ef8a07ec40fa38b766d0bf9061fcde3/package.json#L47-L49
vitejs/vite#20822
rolldown/rolldown#6141
closes: #63510
Was generative AI tooling used to co-author this PR?
No