Fix airflowctl pools export ignoring --output table/yaml/plain#62665
Merged
bugraoz93 merged 4 commits intoMar 3, 2026
Conversation
The export command was using `rich.print()` for non-JSON output formats, which printed raw Python repr instead of respecting the user's --output format choice. Use `AirflowConsole().print_as()` to properly format output as table, yaml, or plain text. Co-Authored-By: claude-flow <ruv@ruv.net>
Leondon9
requested review from
bugraoz93,
dheerajturaga and
potiuk
as code owners
Contributor
|
Thanks for the PR! Could you add a corresponding tests for this? |
Co-Authored-By: claude-flow <ruv@ruv.net>
Leondon9
force-pushed
the
fix/62651-pool-export-output-format
branch
from
e091745 to
47fc0e1
Compare
…trize - assert_called_once_with() to verify both pool data and output format - Parametrize over table/yaml/plain to cover all non-JSON formats Co-Authored-By: claude-flow <ruv@ruv.net>
Co-Authored-By: claude-flow <ruv@ruv.net>
Contributor
Author
I've added the corresponding tests for non-JSON outputs in the latest commits. |
18 tasks
dominikhei
pushed a commit
to dominikhei/airflow
that referenced
this pull request
Mar 11, 2026
…che#62665) * Fix `airflowctl pools export` ignoring --output table/yaml/plain The export command was using `rich.print()` for non-JSON output formats, which printed raw Python repr instead of respecting the user's --output format choice. Use `AirflowConsole().print_as()` to properly format output as table, yaml, or plain text. Co-Authored-By: claude-flow <ruv@ruv.net> * Add test verifying non-JSON pool export delegates to AirflowConsole Co-Authored-By: claude-flow <ruv@ruv.net> * Strengthen non-JSON export test with argument verification and parametrize - assert_called_once_with() to verify both pool data and output format - Parametrize over table/yaml/plain to cover all non-JSON formats Co-Authored-By: claude-flow <ruv@ruv.net> * Use keyword args for print_as to match other airflow-ctl commands Co-Authored-By: claude-flow <ruv@ruv.net> --------- Co-authored-by: claude-flow <ruv@ruv.net>
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
airflowctl pools exportaccepts--output table|yaml|plainbut only handlesjsonproperly. For all other formats, it falls through torich.print(pools_list)which outputs raw Python list repr instead of formatted output.This replaces the raw
rich.print()call withAirflowConsole().print_as(), which already supports all 4 output formats and is used by other airflow-ctl commands.closes: #62651
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (claude-opus-4-6) following the guidelines