Skip to content

fab: centralize FastAPI auth manager routing#61647

Merged
vincbeck merged 3 commits intoapache:mainfrom
henry3260:common-router
Feb 20, 2026
Merged

fab: centralize FastAPI auth manager routing#61647
vincbeck merged 3 commits intoapache:mainfrom
henry3260:common-router

Conversation

@henry3260
Copy link
Contributor

@henry3260 henry3260 commented Feb 8, 2026

What

  • Added shared root routers for FAB auth manager FastAPI routes.
  • login, users, and roles now register endpoints via common routers with a single
    source of truth for prefix/tags.

Why

  • Avoids duplicated prefix/tag definitions across route modules.
  • Makes it easier to change FAB API prefix/tags in one place and reduces the risk of
    drift.

related: #57480 (comment)


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@henry3260 henry3260 force-pushed the common-router branch 2 times, most recently from ac5d3ca to ce4de7a Compare February 12, 2026 17:03
@henry3260 henry3260 force-pushed the common-router branch 2 times, most recently from 239a0a2 to fcfd02b Compare February 13, 2026 10:47
@henry3260
Copy link
Contributor Author

HI @vincbeck , It looks like the FastAPI router isn't registering the endpoints correctly, which is why the generated OpenAPI spec is empty. I suspect we just need to import and include the login, roles, and users sub-routers into the main FAB router. WDYT?

Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a lot of errors, let's try to fix them one by one

@vincbeck vincbeck merged commit 56a26f9 into apache:main Feb 20, 2026
86 checks passed
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
* fab: centralize FastAPI auth manager routing

* Add register_routes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants