Skip to content

Conversation

@jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Jan 24, 2026

While I was hunting for a bug in OAuth I realized that the typing of Python code in Fab is... missing in most part. This PR adds more typing hints to the providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py - and as a consequence I found a lot of warnings and mypy errors alongside which I needed to fix to make tests and mypy happy again.

Not sure whether my type fixes are introducing some kind of breaking changes... but I assume Fab is "not a kind of public API"? Therefore would merge only based on an expert review like @vincbeck or @potiuk


Was generative AI tooling used to co-author this PR?
  • No (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@jscheffl jscheffl requested a review from potiuk January 24, 2026 10:50
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@potiuk potiuk merged commit 8dc960c into apache:main Jan 24, 2026
85 checks passed
suii2210 pushed a commit to suii2210/airflow that referenced this pull request Jan 26, 2026
@vincbeck
Copy link
Contributor

Nice! Thank you :)

shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants