Respect maximum page limit in API #60989
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should respect the
maximum_page_limitas a safety to prevent request with a big limit from overloading the server.If the client specifies a limit that is bigger than the
maximum_page_limitspecified in the conf, the limit will be retained.Note: while working on that, I realised we have two similar options
api.page_sizeandapi.fallback_page_limit. I'll open a follow up PR to deprecatepage_sizeand usefallback_page_limitinstead since it's already the standard in providers too.