Skip to content

Conversation

@pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented Jan 23, 2026

We should respect the maximum_page_limit as a safety to prevent request with a big limit from overloading the server.

If the client specifies a limit that is bigger than the maximum_page_limit specified in the conf, the limit will be retained.

Note: while working on that, I realised we have two similar options api.page_size and api.fallback_page_limit. I'll open a follow up PR to deprecate page_size and use fallback_page_limit instead since it's already the standard in providers too.

@pierrejeambrun pierrejeambrun added this to the Airflow 3.1.7 milestone Jan 23, 2026
@pierrejeambrun pierrejeambrun added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Jan 23, 2026
@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Jan 23, 2026
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@pierrejeambrun pierrejeambrun force-pushed the respect-maximum-page-limit branch from 27ac3e3 to de36444 Compare January 26, 2026 13:01
@pierrejeambrun pierrejeambrun merged commit 2ed3969 into apache:main Jan 26, 2026
245 of 246 checks passed
@pierrejeambrun pierrejeambrun deleted the respect-maximum-page-limit branch January 26, 2026 14:36
github-actions bot pushed a commit that referenced this pull request Jan 26, 2026
* Respect maximum page limit in API

* Fix CI
(cherry picked from commit 2ed3969)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
@github-actions
Copy link

Backport successfully created: v3-1-test

Status Branch Result
v3-1-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jan 26, 2026
* Respect maximum page limit in API

* Fix CI
(cherry picked from commit 2ed3969)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
pierrejeambrun added a commit that referenced this pull request Jan 26, 2026
* Respect maximum page limit in API

* Fix CI
(cherry picked from commit 2ed3969)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
* Respect maximum page limit in API

* Fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants