Skip to content

Conversation

@ephraimbuddy
Copy link
Contributor

Using git provider 0.2.1 with common.compat <1.12 causes issues in dag callbacks

@Prab-27
Copy link
Contributor

Prab-27 commented Jan 23, 2026

Could we update this as - apache-airflow-providers-common-compat>=1.12.0 like teradata and exasol

ephraimbuddy and others added 2 commits January 25, 2026 08:57
Using git provider 0.2.1 with common.compat <1.12 causes issues in dag callbacks
Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
@ephraimbuddy ephraimbuddy force-pushed the update-git-provider-common-req branch from 30c283d to de51ff8 Compare January 25, 2026 07:57
@eladkal
Copy link
Contributor

eladkal commented Jan 25, 2026

I think we have a bug with the # use next version
The test should not fail for this PR

@ephraimbuddy
Copy link
Contributor Author

I think we have a bug with the # use next version The test should not fail for this PR

I remember being told by @jscheffl that the update should only be done by release manager. That was why I used the # use next version

@eladkal
Copy link
Contributor

eladkal commented Jan 26, 2026

I think we have a bug with the # use next version The test should not fail for this PR

I remember being told by @jscheffl that the update should only be done by release manager. That was why I used the # use next version

Added label to override

@jscheffl
Copy link
Contributor

I think we have a bug with the # use next version The test should not fail for this PR

I remember being told by @jscheffl that the update should only be done by release manager. That was why I used the # use next version

No, is only needed if the common.compat also is pending release (because something changed there) so that a marker is there that common-compat has increased version, the dependency is bumped accordingly.

If you are referring to featutes already released in 1.12.0 then it is good.

@eladkal
Copy link
Contributor

eladkal commented Jan 26, 2026

If you are referring to featutes already released in 1.12.0 then it is good.

ideally yes but something is still broken with the scripts as the test is failing. I am not sure if I will have time to look into this in the up coming days

@Prab-27
Copy link
Contributor

Prab-27 commented Jan 27, 2026

Does this fine to update the failing docs checks - here since it's just require dependency docs and get all green to merge this

@eladkal
Copy link
Contributor

eladkal commented Jan 27, 2026

ah yeah
@ephraimbuddy you need to run pre-commits on this PR so index.rst will be updated

@ephraimbuddy ephraimbuddy merged commit 7c1e49a into apache:main Jan 27, 2026
101 checks passed
@ephraimbuddy ephraimbuddy deleted the update-git-provider-common-req branch January 27, 2026 10:40
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks

shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
* Git provider should require common-compat >=1.12.0

Using git provider 0.2.1 with common.compat <1.12 causes issues in dag callbacks

* Update providers/git/pyproject.toml

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>

* fixup! Update providers/git/pyproject.toml

---------

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants