-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Git provider should require common-compat >=1.12.0 #60985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git provider should require common-compat >=1.12.0 #60985
Conversation
|
Could we update this as - |
Using git provider 0.2.1 with common.compat <1.12 causes issues in dag callbacks
Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
30c283d to
de51ff8
Compare
|
I think we have a bug with the |
I remember being told by @jscheffl that the update should only be done by release manager. That was why I used the |
Added label to override |
No, is only needed if the common.compat also is pending release (because something changed there) so that a marker is there that common-compat has increased version, the dependency is bumped accordingly. If you are referring to featutes already released in 1.12.0 then it is good. |
ideally yes but something is still broken with the scripts as the test is failing. I am not sure if I will have time to look into this in the up coming days |
|
Does this fine to update the failing docs checks - here since it's just require dependency docs and get all green to merge this |
|
ah yeah |
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks
* Git provider should require common-compat >=1.12.0 Using git provider 0.2.1 with common.compat <1.12 causes issues in dag callbacks * Update providers/git/pyproject.toml Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com> * fixup! Update providers/git/pyproject.toml --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Using git provider 0.2.1 with common.compat <1.12 causes issues in dag callbacks