Use bulk DELETE for XComModel.clear() instead of loading records
#60955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clear() method was loading all matching XCom records into memory and deleting them one by one. For tasks with many XCom entries, this caused unnecessary memory usage and N+1 DELETE statements. This change uses a single bulk DELETE statement which is both more memory-efficient and faster.
kaxil
changed the title
XComModel.clear() instead of loading records
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the XComModel.clear() method by replacing inefficient record-by-record deletion with a single bulk DELETE operation, improving both memory usage and performance for tasks with many XCom entries.
Changes:
- Replaced
select()+ loop-based deletion with a singledelete()statement - Removed commented-out debug print statement
- Maintained all existing filtering logic (dag_id, task_id, run_id, map_index)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jedcunningham
approved these changes
Jan 22, 2026
suii2210
pushed a commit
to suii2210/airflow
that referenced
this pull request
Jan 26, 2026
…che#60955) The clear() method was loading all matching XCom records into memory and deleting them one by one. For tasks with many XCom entries, this caused unnecessary memory usage and N+1 DELETE statements. This change uses a single bulk DELETE statement which is both more memory-efficient and faster.
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 27, 2026
) The clear() method was loading all matching XCom records into memory and deleting them one by one. For tasks with many XCom entries, this caused unnecessary memory usage and N+1 DELETE statements. This change uses a single bulk DELETE statement which is both more memory-efficient and faster. (cherry picked from commit b651403)
ephraimbuddy
added
the
type:misc/internal
shreyas-dev
pushed a commit
to shreyas-dev/airflow
that referenced
this pull request
Jan 29, 2026
…che#60955) The clear() method was loading all matching XCom records into memory and deleting them one by one. For tasks with many XCom entries, this caused unnecessary memory usage and N+1 DELETE statements. This change uses a single bulk DELETE statement which is both more memory-efficient and faster.
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
XComModel.clear()method was loading all matching XCom records into memory and deleting them one by one:For tasks with many XCom entries (e.g., mapped tasks with many keys), this caused:
This change uses a single bulk DELETE statement:
This is both more memory-efficient and faster.