Fix mypy checks in CI to also run for scripts #60898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mypy Checks in CI have not been run on "scripts" folder - only on dev folder and if a mypy error creeped-in, it remained undetected unless someone run `pre-push` mypy check that instead of folders run it on individual files. This PR fixes the errors that creeped in and fixes the CI so that mypy-dev also checks scripts.
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
kaxil
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
jscheffl
approved these changes
Jan 21, 2026
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Ups, cool! Thanks for fixing!
shahar1
approved these changes
Jan 21, 2026
Member
Author
Thanks to @mlauter for being inquisitive on slack :D |
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 7214ff8 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 21, 2026
Mypy Checks in CI have not been run on "scripts" folder - only on dev folder and if a mypy error creeped-in, it remained undetected unless someone run `pre-push` mypy check that instead of folders run it on individual files. This PR fixes the errors that creeped in and fixes the CI so that mypy-dev also checks scripts. (cherry picked from commit 7214ff8) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Member
Author
|
Backport in #60906 |
potiuk
added a commit
that referenced
this pull request
Jan 22, 2026
…60906) Mypy Checks in CI have not been run on "scripts" folder - only on dev folder and if a mypy error creeped-in, it remained undetected unless someone run `pre-push` mypy check that instead of folders run it on individual files. This PR fixes the errors that creeped in and fixes the CI so that mypy-dev also checks scripts. (cherry picked from commit 7214ff8)
suii2210
pushed a commit
to suii2210/airflow
that referenced
this pull request
Jan 26, 2026
Mypy Checks in CI have not been run on "scripts" folder - only on dev folder and if a mypy error creeped-in, it remained undetected unless someone run `pre-push` mypy check that instead of folders run it on individual files. This PR fixes the errors that creeped in and fixes the CI so that mypy-dev also checks scripts.
shreyas-dev
pushed a commit
to shreyas-dev/airflow
that referenced
this pull request
Jan 29, 2026
Mypy Checks in CI have not been run on "scripts" folder - only on dev folder and if a mypy error creeped-in, it remained undetected unless someone run `pre-push` mypy check that instead of folders run it on individual files. This PR fixes the errors that creeped in and fixes the CI so that mypy-dev also checks scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy Checks in CI have not been run on "scripts" folder - only on dev folder and if a mypy error creeped-in, it remained undetected unless someone run
pre-pushmypy check that instead of folders run it on individual files.This PR fixes the errors that creeped in and fixes the CI so that mypy-dev also checks scripts.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.