Fix running task marked as failed on Celery broker redelivery #58441 #60855
+131
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anishgirianish
requested review from
amoghrajesh,
ashb,
dheerajturaga,
hussein-awala and
kaxil
as code owners
2 tasks
anishgirianish
force-pushed
the
fix/58441-fix-celery-task-marked-as-failed
branch
from
116a330 to
c991bc6
Compare
ashb
reviewed
Jan 27, 2026
| ) | ||
| except Exception as e: | ||
| if TaskAlreadyRunningError is not None and isinstance(e, TaskAlreadyRunningError): | ||
| log.info("[%s] Task already running elsewhere, ignoring redelivered message", celery_task_id) |
Member
There was a problem hiding this comment.
Is this a new feature or did something like this exist in Airflow 2.x?
ashb
reviewed
Jan 27, 2026
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
It's not clear to me why we need this "Ignore" behaviour?
Comment on lines
+1018
to
+1024
| if isinstance(detail, dict) and "detail" in detail: | ||
| detail = detail["detail"] | ||
| if ( | ||
| isinstance(detail, dict) | ||
| and detail.get("reason") == "invalid_state" | ||
| and detail.get("previous_state") == "running" | ||
| ): |
Member
There was a problem hiding this comment.
This is rather fragile and not a good idea to write things this way.
| return exit_code | ||
| except TaskAlreadyRunningError: | ||
| # Let the executor handle this (e.g., Celery will ignore it) | ||
| log.info("Exiting due to broker redelivery", task_instance_id=str(ti.id)) |
Member
There was a problem hiding this comment.
"broker" as a concept only exist for Celery, so this log message doesn't make sense for other executors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TaskAlreadyRunningErrorIgnore()to prevent state reportingcloses #58441
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.