Skip to content

Fix slow log scrolling for large task logs #60806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pierrejeambrun merged 2 commits into from
Jan 21, 2026
Merged

Fix slow log scrolling for large task logs #60806

pierrejeambrun merged 2 commits into from
Jan 21, 2026

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented Jan 20, 2026 •
edited
Loading

Related Issue

Ref #54447
Closes #51788

Why

Scrolling to the end of large log files was slow because the virtualizer had to compute positions for all rows. This fix:

How

  • Use scrollToOffset with direct offset calculation for instant jumps
  • Add useLocation hook so clicking a log line highlights it reactively
  • Extract scroll utilities to utils.ts
Screen.Recording.2026-01-20.at.12.46.05.PM.mov
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    Claude Code
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 20, 2026
@guan404ming guan404ming force-pushed the fix-log-scroll-performance branch 2 times, most recently from 7779ef4 to faf2e1a Compare January 20, 2026 04:49
@guan404ming guan404ming marked this pull request as ready for review January 20, 2026 05:53
pierrejeambrun
pierrejeambrun reviewed Jan 20, 2026
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, would be great to have this scroll to bottom / top fixed!

Just a few comments, but tested locally and working as expected, we just need to trim down the PR to focus on this part only while we figure out the rest.

@guan404ming guan404ming force-pushed the fix-log-scroll-performance branch from faf2e1a to 983b18c Compare January 20, 2026 16:40
bbovenzi
bbovenzi reviewed Jan 20, 2026
View reviewed changes
@guan404ming guan404ming force-pushed the fix-log-scroll-performance branch from 983b18c to dec55fb Compare January 21, 2026 02:45
@guan404ming guan404ming force-pushed the fix-log-scroll-performance branch from dec55fb to fecf46a Compare January 21, 2026 02:47
@pierrejeambrun pierrejeambrun merged commit 4766f9c into apache:main Jan 21, 2026
77 checks passed
pierrejeambrun pushed a commit to astronomer/airflow that referenced this pull request Jan 21, 2026
@guan404ming @pierrejeambrun
Fix slow log scrolling for large task logs (apache#60806)
e241a52 
* Fix slow log scrolling for large task logs

* Trim to focus on scroll top/bottom

(cherry picked from commit 4766f9c)
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Jan 21, 2026

Manual backport #60875

@guan404ming guan404ming deleted the fix-log-scroll-performance branch January 21, 2026 15:01
@guan404ming
Copy link
Member Author

guan404ming commented Jan 21, 2026

Thanks!

pierrejeambrun added a commit that referenced this pull request Jan 21, 2026
@pierrejeambrun @guan404ming
Fix slow log scrolling for large task logs (#60806) (#60875)
f21d199 
* Fix slow log scrolling for large task logs

* Trim to focus on scroll top/bottom

(cherry picked from commit 4766f9c)

Co-authored-by: Guan-Ming (Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
suii2210 pushed a commit to suii2210/airflow that referenced this pull request Jan 26, 2026
@guan404ming @suii2210
Fix slow log scrolling for large task logs (apache#60806)
663bb07 
* Fix slow log scrolling for large task logs

* Trim to focus on scroll top/bottom
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
@guan404ming @shreyas-dev
Fix slow log scrolling for large task logs (apache#60806)
fd3fe5b 
* Fix slow log scrolling for large task logs

* Trim to focus on scroll top/bottom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbovenzi bbovenzi bbovenzi approved these changes

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

@vatsrahul1001 vatsrahul1001 Awaiting requested review from vatsrahul1001 vatsrahul1001 is a code owner

@choo121600 choo121600 Awaiting requested review from choo121600 choo121600 is a code owner

Assignees

No one assigned

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scrolling in logs does not work properly.

3 participants

@guan404ming @pierrejeambrun @bbovenzi