Define TaskInstanceKey in task-sdk to support client server separation
#60776
+88
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
ashb,
eladkal,
kaxil,
potiuk and
uranusjr
and removed request for
ashb and
kaxil
kaxil
reviewed
Jan 19, 2026
kaxil
reviewed
Jan 19, 2026
amoghrajesh
requested review from
dabla,
dheerajturaga,
hussein-awala,
jedcunningham,
jscheffl,
o-nikolas and
shahar1
as code owners
Contributor
Author
|
This one needs a bit more work to fix CI |
Contributor
Author
|
Umm this databricks failure will need some ground work, its using the old signature to support AF2 |
kaxil
reviewed
Jan 22, 2026
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kubernetes_helper_functions.py
Show resolved
Hide resolved
kaxil
reviewed
Jan 22, 2026
providers/databricks/src/airflow/providers/databricks/plugins/databricks_workflow.py
Show resolved
Hide resolved
kaxil
reviewed
Jan 22, 2026
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py
Show resolved
Hide resolved
kaxil
approved these changes
Jan 22, 2026
Member
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
High lgtm but do have some questions
amoghrajesh
commented
Jan 23, 2026
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py
Show resolved
Hide resolved
suii2210
pushed a commit
to suii2210/airflow
that referenced
this pull request
Jan 26, 2026
85 tasks
shreyas-dev
pushed a commit
to shreyas-dev/airflow
that referenced
this pull request
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
Defining
TaskInstanceKeyin task-sdk as exposing it as a part of the SDK public API. This enables providers to useTaskInstanceKeywithout depending on airflow-core models (older path).For context,
TaskInstanceKeyprovides task information(dag_id, task_id, run_id, map_index, try_number)which is used now for:Why not follow this comment: https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/executors/workloads.py#L77 and actually do it? There are a few blockers to that.
TaskInstanceKeystill remains as the interface for public APIs and provider contracts due to backcompat (airflow 2.x doesn't haveuuid)Whats next?