-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Pin fastavro to minimum 1.10.0 for Python 3.13 compatibility #60732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks Jens! |
| ] | ||
| "avro" = [ | ||
| "fastavro>=1.9.0" | ||
| 'fastavro>=1.10.0;python_version>="3.12"' # Need to pin to this version for Python 3.13 compatibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come the python version is 3.12 here and 3.13 elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I should have not lost the previous pinning for all Python versions <3.13. It was mainly added becasuse Python 3.13 needs at least 1.10. But the other should not be replaced.
Might be by accident so far not detected as the optional dependency is not used in CI and only picked if manually selected to install.
Will raise a corrective PR later today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #60797
…60732) * Pin fastavro to minimum 1.10.0 for Python 3.13 compatibility * Pin fastavro to minimum 1.10.0 for Python 3.13 compatibility
…60732) * Pin fastavro to minimum 1.10.0 for Python 3.13 compatibility * Pin fastavro to minimum 1.10.0 for Python 3.13 compatibility
As we see CI failing on fastavro with Python 3.13 - see #60543 (comment) - this PR bumps fastavro to be 1.10 at least
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.