-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Improve dag_bundle_config_list Configuration in Airflow Helm Chart #60645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dag_bundle_config_list Configuration in Airflow Helm Chart #60645
Conversation
3c59689 to
61b69a2
Compare
61b69a2 to
0641f54
Compare
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests are missing - can you add some please?
Thank you for the feedback. I've updated the PR with the following changes:
|
ecf3957 to
eb4dacb
Compare
choo121600
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit suggestion:
we’ve agreed to refer to DAG as Dag going forward.
It would be great if you could update the occurrences accordingly :)
[VOTE] results as of https://lists.apache.org/thread/0651j4vdgzmlhgndmotvznlg97kyh328
Great catch, thank you for sharing the discussion link. I've gone through the PR and adjusted |
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me.
…pache#60645) * Improve dag_bundle_config_list Configuration in Airflow Helm Chart * Apply review of @jscheffi - Mark config.dag_processor.dag_bundle_config_list as deprecated * Apply review of @jscheffi - Add test for dagProcessor.dag_bundles * Rename dag_bundles to dagBundleConfigList for consistency * Apply review of @choo121600 - Update term DAG -> Dag
…pache#60645) * Improve dag_bundle_config_list Configuration in Airflow Helm Chart * Apply review of @jscheffi - Mark config.dag_processor.dag_bundle_config_list as deprecated * Apply review of @jscheffi - Add test for dagProcessor.dag_bundles * Rename dag_bundles to dagBundleConfigList for consistency * Apply review of @choo121600 - Update term DAG -> Dag


Overview
Related Issue: #60630
Improve
dag_bundle_config_listConfiguration in Airflow Helm ChartThis PR improves the
dag_bundle_config_listconfiguration in the Airflow Helm Chart by allowing users to define DAG bundle configurations in a structured YAML format instead of requiring a JSON string directly in the values file.Changes
dag_bundlessection underdagProcessorinvalues.yamlthat allows users to define DAG bundles in a structured YAML formatdag_bundlesthat automatically converts the YAML structure to the required JSON string formatdagProcessor.dag_bundleswith a local DAG bundle configurationconfig.dag_processor.dag_bundle_config_listto use the helper functiondag_bundlesconfiguration underdagProcessorsection for better logical groupingBenefits
dagProcessorsection.Usage
Users can now define DAG bundles like this:
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.