Explicitly set table ordering #60609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Just one remark otherwise looking good to me.
The sort handler for tansStack/table was inconsistent with when it cycled between sort states if it had a default value. Implementing it ourselves makes sure it always appears.
I wasn't able to reproduce this, can you give more details as to what was happening? (for me it was correctly switching for desc/asc/default).
airflow-core/src/airflow/ui/src/pages/TaskInstances/TaskInstances.tsx
Outdated
Show resolved
Hide resolved
bbovenzi
force-pushed
the
fix-table-sorting
branch
from
fa61038 to
574c18e
Compare
choo121600
reviewed
Jan 22, 2026
Member
choo121600
left a comment
choo121600
left a comment
There was a problem hiding this comment.
Cool, looks good.
It looks like the e2e tests are failing. Could you please check?
bbovenzi
added
the
backport-to-v3-1-test
github-actions bot
pushed a commit
that referenced
this pull request
Jan 29, 2026
* Explicitly set table ordering * Remove start_date as default * simplify comments * Simplify table sort fix * Reverse sort direction to match tests * Remove isfetching (cherry picked from commit d81a4eb) Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Backport successfully created: v3-1-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jan 29, 2026
* Explicitly set table ordering * Remove start_date as default * simplify comments * Simplify table sort fix * Reverse sort direction to match tests * Remove isfetching (cherry picked from commit d81a4eb) Co-authored-by: Brent Bovenzi <brent@astronomer.io>
shahar1
pushed a commit
that referenced
this pull request
Jan 29, 2026
sanchalitorpe-source
pushed a commit
to sanchalitorpe-source/airflow
that referenced
this pull request
Jan 30, 2026
* Explicitly set table ordering * Remove start_date as default * simplify comments * Simplify table sort fix * Reverse sort direction to match tests * Remove isfetching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sort handler for tansStack/table was inconsistent with when it cycled between sort states if it had a default value. Implementing it ourselves makes sure it always appears.
Closes #60576
Also, added add a placeholder data of the previous data to prevent the whole table from showing a loading page when a user does change the sorting.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.