-
Notifications
You must be signed in to change notification settings - Fork 16.4k
reformat add proxy support commit #60432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Reformatting of previous merge which was closed without being added |
|
New merge request should resolve previous static errors and issue with using conn_params = hook._get_conn_params not conn_params = hook._get_conn_params() |
…dj3/airflow into snowflake-proxy-support
|
somehow managed to only delete one of two trailing spaces on line 439 :| |
|
@potiuk can you review out this request when you get the chance? Reasonably simple change to add proxy support to the snowflake hook but if you have any suggestions let me know |
|
You should make sure if proxy_password is masked automaticall when logging connection - look at our secrets masker - I am not sure if "proxy_password" will be redacted automatically by password substring in the name, or whether you need to update the default fields to contain proxy_password or maybe implement partial match when masking values. |
|
I've added proxy_password to the default DEFAULT_SENSITIVE_FIELDS variables in secret masker, I think because it had both proxy and password in the name it probably would have been masked but given how complex the logic is I'd rather play it safe and remove if not needed. |
Yeah |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* reformat add proxy support commit * static errors fix, fixes get_conn_params() causing method is not subscriptable error * static * add proxy_password as default sensitive field
* reformat add proxy support commit * static errors fix, fixes get_conn_params() causing method is not subscriptable error * static * add proxy_password as default sensitive field
This change enables users to configure proxy settings directly in Snowflake connections via extra parameters instead of relying solely on system environment variables, providing better isolation and control.
What changes:
Why:
Tests:
Closes: #59078