Skip to content

Remove the compatibility shim for log_task_event AwsEcsExecutor and AwsBatchExecutor #60301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jan 9, 2026
Merged

Remove the compatibility shim for log_task_event AwsEcsExecutor and AwsBatchExecutor #60301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions providers/amazon/src/airflow/providers/amazon/aws/executors/batch/batch_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import time
from collections import deque
from collections.abc import Sequence
from contextlib import suppress
from copy import deepcopy
from typing import TYPE_CHECKING, Any

Expand Down Expand Up @@ -508,12 +507,3 @@ def try_adopt_task_instances(self, tis: Sequence[TaskInstance]) -> Sequence[Task

not_adopted_tis = [ti for ti in tis if ti not in adopted_tis]
return not_adopted_tis

def log_task_event(self, *, event: str, extra: str, ti_key: TaskInstanceKey):
# TODO: remove this method when min_airflow_version is set to higher than 2.10.0
with suppress(AttributeError):
super().log_task_event(
event=event,
extra=extra,
ti_key=ti_key,
)
10 changes: 0 additions & 10 deletions providers/amazon/src/airflow/providers/amazon/aws/executors/ecs/ecs_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import time
from collections import defaultdict, deque
from collections.abc import Sequence
from contextlib import suppress
from copy import deepcopy
from typing import TYPE_CHECKING

Expand Down Expand Up @@ -606,12 +605,3 @@ def try_adopt_task_instances(self, tis: Sequence[TaskInstance]) -> Sequence[Task

not_adopted_tis = [ti for ti in tis if ti not in adopted_tis]
return not_adopted_tis

def log_task_event(self, *, event: str, extra: str, ti_key: TaskInstanceKey):
# TODO: remove this method when min_airflow_version is set to higher than 2.10.0
with suppress(AttributeError):
super().log_task_event(
event=event,
extra=extra,
ti_key=ti_key,
)