Fixed timestamp comparison bug in S3 hook sync method #60299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
|
Amazing, thanks for this. |
uranusjr
approved these changes
Jan 8, 2026
potiuk
approved these changes
Jan 9, 2026
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_sync_to_local_dir_if_changedmethod in theS3Hook, which checks if the local file differs from the file in S3 was incorrectly comparing last modified dates. It was comparing a unix timestamp (local_stats.st_mtime) tos3_last_modified.microseconds, which only gives the microseconds portion of the date. This meant that unless the last modified date was in Jan 1970, this would always evaluate to false. I changeds3_last_modifiedto use.timestamp()which returns a unix timestamp so that we can compare correctly. I also added an additional test case to ensure a file with the same size but different last modified date (local < s3) gets downloaded as we didn't have a test case for that.related: #60223
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.