-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Automatically add pydantic extra when installing airflow 2 in breeze #60264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing Airflow 2 in Breeze, we need to add pydantic as extra, because pydantic in Airflow 2 was not a required dependency and installation of airflow even with constraints willl not downgrade pydantic to the version that was supported in Airflow 2. When we detect that airflow 2 is installed (either by specified version number or by retrieving the version from the dist package) we simply extend the extras with pydantic and that causes airflow installation to downgrade pydantic to the version that is specified in constraints of selected airflow version.
jason810496
approved these changes
Jan 8, 2026
gopidesupavan
approved these changes
Jan 8, 2026
vincbeck
approved these changes
Jan 8, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
…2 in breeze (#60264) When installing Airflow 2 in Breeze, we need to add pydantic as extra, because pydantic in Airflow 2 was not a required dependency and installation of airflow even with constraints willl not downgrade pydantic to the version that was supported in Airflow 2. When we detect that airflow 2 is installed (either by specified version number or by retrieving the version from the dist package) we simply extend the extras with pydantic and that causes airflow installation to downgrade pydantic to the version that is specified in constraints of selected airflow version. (cherry picked from commit 336b816) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
Jan 9, 2026
…2 in breeze (#60264) (#60267) When installing Airflow 2 in Breeze, we need to add pydantic as extra, because pydantic in Airflow 2 was not a required dependency and installation of airflow even with constraints willl not downgrade pydantic to the version that was supported in Airflow 2. When we detect that airflow 2 is installed (either by specified version number or by retrieving the version from the dist package) we simply extend the extras with pydantic and that causes airflow installation to downgrade pydantic to the version that is specified in constraints of selected airflow version. (cherry picked from commit 336b816) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
chirodip98
pushed a commit
to chirodip98/airflow-contrib
that referenced
this pull request
Jan 9, 2026
…pache#60264) When installing Airflow 2 in Breeze, we need to add pydantic as extra, because pydantic in Airflow 2 was not a required dependency and installation of airflow even with constraints willl not downgrade pydantic to the version that was supported in Airflow 2. When we detect that airflow 2 is installed (either by specified version number or by retrieving the version from the dist package) we simply extend the extras with pydantic and that causes airflow installation to downgrade pydantic to the version that is specified in constraints of selected airflow version.
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
…pache#60264) When installing Airflow 2 in Breeze, we need to add pydantic as extra, because pydantic in Airflow 2 was not a required dependency and installation of airflow even with constraints willl not downgrade pydantic to the version that was supported in Airflow 2. When we detect that airflow 2 is installed (either by specified version number or by retrieving the version from the dist package) we simply extend the extras with pydantic and that causes airflow installation to downgrade pydantic to the version that is specified in constraints of selected airflow version.
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 13, 2026
…2 in breeze (#60264) (#60267) When installing Airflow 2 in Breeze, we need to add pydantic as extra, because pydantic in Airflow 2 was not a required dependency and installation of airflow even with constraints willl not downgrade pydantic to the version that was supported in Airflow 2. When we detect that airflow 2 is installed (either by specified version number or by retrieving the version from the dist package) we simply extend the extras with pydantic and that causes airflow installation to downgrade pydantic to the version that is specified in constraints of selected airflow version. (cherry picked from commit 336b816) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 14, 2026
…2 in breeze (#60264) (#60267) When installing Airflow 2 in Breeze, we need to add pydantic as extra, because pydantic in Airflow 2 was not a required dependency and installation of airflow even with constraints willl not downgrade pydantic to the version that was supported in Airflow 2. When we detect that airflow 2 is installed (either by specified version number or by retrieving the version from the dist package) we simply extend the extras with pydantic and that causes airflow installation to downgrade pydantic to the version that is specified in constraints of selected airflow version. (cherry picked from commit 336b816) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 16, 2026
…2 in breeze (#60264) (#60267) When installing Airflow 2 in Breeze, we need to add pydantic as extra, because pydantic in Airflow 2 was not a required dependency and installation of airflow even with constraints willl not downgrade pydantic to the version that was supported in Airflow 2. When we detect that airflow 2 is installed (either by specified version number or by retrieving the version from the dist package) we simply extend the extras with pydantic and that causes airflow installation to downgrade pydantic to the version that is specified in constraints of selected airflow version. (cherry picked from commit 336b816) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing Airflow 2 in Breeze, we need to add pydantic as extra, because pydantic in Airflow 2 was not a required dependency and installation of airflow even with constraints willl not downgrade pydantic to the version that was supported in Airflow 2.
When we detect that airflow 2 is installed (either by specified version number or by retrieving the version from the dist package) we simply extend the extras with pydantic and that causes airflow installation to downgrade pydantic to the version that is specified in constraints of selected airflow version.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.