-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Inherit core theme in React plugins #60256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inherit core theme in React plugins #60256
Conversation
35a87a7 to
b9e612d
Compare
bbovenzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call!
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 3e57f1e v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
(cherry picked from commit 3e57f1e)
|
Manual backport #60405 |
|
If I apply this change on Edge provider plugin, does this break compatibility with Airflow <3.1.6? Or is it backwards-compatible? |
|
This is backward compatible. (I mean nothing breaks):
PR here for edge provider: |
Remove some unnecessary code so React Plugins can directly inherit the Chakra Theme for Airflow Core without duplicating or copy pasting any core theme.
Now in local development, we use Chakra default theme (black).

When loaded into airflow, nothing changes, theme is smooth and consistent:

Also importantly this fixes an issue where the 'plugin theme' when loaded would override the core theme. (which is not what we want). This was an issue for instance if I customized my core theme via the
api.themeconfig option, then loading the plugin would restore back theAirflow Core UIdefault theme that was hard copy/pasted into plugins.Now with a custom core theme, the UI and plugins are correctly customized:
