Remove unused logic in helm_template_generator #60188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
jedcunningham
approved these changes
Jan 6, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
(cherry picked from commit 6181c3f) Co-authored-by: Przemysław Mirowski <miretpl@gmail.com>
Backport successfully created: v3-1-test
|
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 14, 2026
(cherry picked from commit 6181c3f) Co-authored-by: Przemysław Mirowski <miretpl@gmail.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 14, 2026
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 14, 2026
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 16, 2026
jason810496
pushed a commit
to jason810496/airflow
that referenced
this pull request
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we have some logic unused by Helm Chart during its tests in helm_template_generator.py. We have not been using the
networking.k8s.io/v1beta1API in our chart for quite some time (probably since Helm Chart 1.8.0 - PR which partially removed beta from the chart - #28461).^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.