-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Test: Add E2E tests for Assets Page #59990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Add E2E tests for Assets Page #59990
Conversation
|
@sarth-akvaish can you look at failing tests? |
|
@sarth-akvaish Thanks for the PR! A few things to address:
Also maybe trigger multiple dags which uses assets and it will help in search test to filter
Let me know if you have questions |
Hi @vatsrahul1001, Thanks for the review. I’ll incorporate the suggested changes and update the PR. |
49936ed to
f8f7d9a
Compare
|
Hi @vatsrahul1001 , currently in beforeAll I'm triggering a DAG, and checking its status in the run tab (using polling), Should I have to check the status of Dag run ? If yes, then current one is giving flaky test, can I test using rest api endpoints? |
f8f7d9a to
5e55b8a
Compare
Yes we can use RESTAPI and have added this in suggested change |
|
@sarth-akvaish we are missing test for |
5e55b8a to
2ccd01a
Compare
2ccd01a to
b8c4c15
Compare
|
Great work @sarth-akvaish merging the PR |
- Rename AssetsPage to AssetDetailPage for clarity (coordinates with apache#59990) - Add beforeAll to trigger asset_produces_1 DAG before tests - Fix fragile selectors (use parent container + ARIA roles) - Refactor duplicate code into verifyStatSection helper - Remove unused assetsTable locator - Rename test to remove 'should' prefix - Change describe name to 'Asset Details Page'
* Update release command and guide Update some of the issues I noticed during the release * fixup! Test: Add E2E tests for Assets Page (#59990) * Apply suggestion from @ephraimbuddy * fixup! fixup! Test: Add E2E tests for Assets Page (#59990)
* Update release command and guide Update some of the issues I noticed during the release * fixup! Test: Add E2E tests for Assets Page (#59990) * Apply suggestion from @ephraimbuddy * fixup! fixup! Test: Add E2E tests for Assets Page (#59990) (cherry picked from commit 2de609e) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
* Update release command and guide Update some of the issues I noticed during the release * fixup! Test: Add E2E tests for Assets Page (apache#59990) * Apply suggestion from @ephraimbuddy * fixup! fixup! Test: Add E2E tests for Assets Page (apache#59990) (cherry picked from commit 2de609e) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
* Update release command and guide Update some of the issues I noticed during the release * fixup! Test: Add E2E tests for Assets Page (#59990) * Apply suggestion from @ephraimbuddy * fixup! fixup! Test: Add E2E tests for Assets Page (#59990) (cherry picked from commit 2de609e) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
* Update release command and guide Update some of the issues I noticed during the release * fixup! Test: Add E2E tests for Assets Page (#59990) * Apply suggestion from @ephraimbuddy * fixup! fixup! Test: Add E2E tests for Assets Page (#59990) (cherry picked from commit 2de609e) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
Test: Add E2E tests for Assets Page (apache#59990) Co-authored-by: vatsrahul1001 <rah.sharma11@gmail.com> Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
* Update release command and guide Update some of the issues I noticed during the release * fixup! Test: Add E2E tests for Assets Page (apache#59990) * Apply suggestion from @ephraimbuddy * fixup! fixup! Test: Add E2E tests for Assets Page (apache#59990)
This PR adds the E2E tests for Assets Page.
The test now verfies:
Closes : #59929
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.