Skip to content

Conversation

@sarth-akvaish
Copy link
Contributor

This PR adds the E2E tests for Assets Page.

The test now verfies:

  • Assets are listed in the table
  • Asset name are visible
  • Clicking on an asset name navigates to asset detail page
  • working of search filters and pagination

Closes : #59929


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Dec 31, 2025
@vatsrahul1001
Copy link
Contributor

@sarth-akvaish can you look at failing tests?

@vatsrahul1001
Copy link
Contributor

vatsrahul1001 commented Jan 6, 2026

@sarth-akvaish Thanks for the PR! A few things to address:

  1. Add beforeAll to trigger producer DAG - Tests assume assets exist. Add setup that unpause consumer DAG and triggers asset_produces_1 to create real asset data:
    test.beforeAll(async ({ browser }) => {
    // Trigger asset_produces_1 to create asset data
    });

Also maybe trigger multiple dags which uses assets and it will help in search test to filter
2. Coordinate with PR #59939 - Both PRs create different page objects. Work together to use single AssetsPage.ts and assets.spec.ts

  1. Test naming - Use "verify" prefix
  2. Fix fragile selectors - Be more specific
  3. Pagination - Use ?offset=0&limit=1 URL param

Let me know if you have questions

@sarth-akvaish
Copy link
Contributor Author

@sarth-akvaish Thanks for the PR! A few things to address:

  1. Add beforeAll to trigger producer DAG - Tests assume assets exist. Add setup that unpause consumer DAG and triggers asset_produces_1 to create real asset data:
    test.beforeAll(async ({ browser }) => {
    // Trigger asset_produces_1 to create asset data
    });

Also maybe trigger multiple dags which uses assets and it will help in search test to filter 2. Coordinate with PR #59939 - Both PRs create different page objects. Work together to use single AssetsPage.ts and assets.spec.ts

  1. Test naming - Use "verify" prefix
  2. Fix fragile selectors - Be more specific
  3. Pagination - Use ?offset=0&limit=1 URL param

Let me know if you have questions

Hi @vatsrahul1001, Thanks for the review. I’ll incorporate the suggested changes and update the PR.

@sarth-akvaish sarth-akvaish force-pushed the test/Tests-for-Assets-Page branch from 49936ed to f8f7d9a Compare January 8, 2026 11:20
@sarth-akvaish
Copy link
Contributor Author

Hi @vatsrahul1001 , currently in beforeAll I'm triggering a DAG, and checking its status in the run tab (using polling), Should I have to check the status of Dag run ? If yes, then current one is giving flaky test, can I test using rest api endpoints?

@sarth-akvaish sarth-akvaish force-pushed the test/Tests-for-Assets-Page branch from f8f7d9a to 5e55b8a Compare January 8, 2026 13:51
@vatsrahul1001
Copy link
Contributor

Hi @vatsrahul1001 , currently in beforeAll I'm triggering a DAG, and checking its status in the run tab (using polling), Should I have to check the status of Dag run ? If yes, then current one is giving flaky test, can I test using rest api endpoints?

Yes we can use RESTAPI and have added this in suggested change

@vatsrahul1001
Copy link
Contributor

@sarth-akvaish we are missing test for verify clicking asset navigates to detail page

@sarth-akvaish sarth-akvaish force-pushed the test/Tests-for-Assets-Page branch from 5e55b8a to 2ccd01a Compare January 9, 2026 17:44
@sarth-akvaish sarth-akvaish force-pushed the test/Tests-for-Assets-Page branch from 2ccd01a to b8c4c15 Compare January 9, 2026 18:58
@vatsrahul1001
Copy link
Contributor

Great work @sarth-akvaish merging the PR

@vatsrahul1001 vatsrahul1001 merged commit 76cc6de into apache:main Jan 14, 2026
77 checks passed
ephraimbuddy added a commit to astronomer/airflow that referenced this pull request Jan 14, 2026
junaiddshaukat added a commit to junaiddshaukat/airflow that referenced this pull request Jan 15, 2026
- Rename AssetsPage to AssetDetailPage for clarity (coordinates with apache#59990)
- Add beforeAll to trigger asset_produces_1 DAG before tests
- Fix fragile selectors (use parent container + ARIA roles)
- Refactor duplicate code into verifyStatSection helper
- Remove unused assetsTable locator
- Rename test to remove 'should' prefix
- Change describe name to 'Asset Details Page'
ephraimbuddy added a commit to astronomer/airflow that referenced this pull request Jan 15, 2026
ephraimbuddy added a commit to astronomer/airflow that referenced this pull request Jan 15, 2026
ephraimbuddy added a commit that referenced this pull request Jan 15, 2026
* Update release command and guide

Update some of the issues I noticed during the release

* fixup! Test: Add E2E tests for Assets Page (#59990)

* Apply suggestion from @ephraimbuddy

* fixup! fixup! Test: Add E2E tests for Assets Page (#59990)
github-actions bot pushed a commit that referenced this pull request Jan 15, 2026
* Update release command and guide

Update some of the issues I noticed during the release

* fixup! Test: Add E2E tests for Assets Page (#59990)

* Apply suggestion from @ephraimbuddy

* fixup! fixup! Test: Add E2E tests for Assets Page (#59990)
(cherry picked from commit 2de609e)

Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jan 15, 2026
* Update release command and guide

Update some of the issues I noticed during the release

* fixup! Test: Add E2E tests for Assets Page (apache#59990)

* Apply suggestion from @ephraimbuddy

* fixup! fixup! Test: Add E2E tests for Assets Page (apache#59990)
(cherry picked from commit 2de609e)

Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
potiuk pushed a commit that referenced this pull request Jan 15, 2026
* Update release command and guide

Update some of the issues I noticed during the release

* fixup! Test: Add E2E tests for Assets Page (#59990)

* Apply suggestion from @ephraimbuddy

* fixup! fixup! Test: Add E2E tests for Assets Page (#59990)
(cherry picked from commit 2de609e)

Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
ephraimbuddy added a commit that referenced this pull request Jan 16, 2026
* Update release command and guide

Update some of the issues I noticed during the release

* fixup! Test: Add E2E tests for Assets Page (#59990)

* Apply suggestion from @ephraimbuddy

* fixup! fixup! Test: Add E2E tests for Assets Page (#59990)
(cherry picked from commit 2de609e)

Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
jason810496 pushed a commit to jason810496/airflow that referenced this pull request Jan 22, 2026
Test: Add E2E tests for Assets Page (apache#59990)
Co-authored-by: vatsrahul1001 <rah.sharma11@gmail.com>
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
jason810496 pushed a commit to jason810496/airflow that referenced this pull request Jan 22, 2026
* Update release command and guide

Update some of the issues I noticed during the release

* fixup! Test: Add E2E tests for Assets Page (apache#59990)

* Apply suggestion from @ephraimbuddy

* fixup! fixup! Test: Add E2E tests for Assets Page (apache#59990)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI E2E Test || ASSET-001: Verify Assets List Displays

2 participants