-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Source conf from airflow.sdk.configuration.conf for apache providers
#59966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source conf from airflow.sdk.configuration.conf for apache providers
#59966
Conversation
airflow.sdk.configuration.confairflow.sdk.configuration.conf
49b5ac8 to
b2c0a12
Compare
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me. Is there a reason the PR is a draft one?
airflow.sdk.configuration.confairflow.sdk.configuration.conf for apache providers
I was waiting for your opinion on the approach. It ready for review now |
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
I will create a larger issue now for all providers after this is merged. |
apache#59966) * Migrate apache provider to use airflow.sdk.configuration.conf * Add 'use next version' comment for common-compat dependency
apache#59966) * Migrate apache provider to use airflow.sdk.configuration.conf * Add 'use next version' comment for common-compat dependency
This PR migrates the apache provider to use
airflow.sdk.configuration.confinstead ofairflow.configuration.conf. This change maintains backward compatibility through the common compat module.Changes
Added
confto common compat moduleUpdated all apache provider file to use conf from common compat module.
related: #60000
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.