-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Improve FastApi exclusion for Cadwyn incompatibility and link Cadwyn … #59859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve FastApi exclusion for Cadwyn incompatibility and link Cadwyn … #59859
Conversation
…issue Cadwyn is not compatible (yet) with FastAPI 0.128.0 - but the changes in FastAPI are deliberately breaking so there is no way we are going to support FastAPI >=0.128.0 unless there is a fix from Cadwyn (and we also need to fix generating models for task-sdk to not use private method that has been removed in FastAPI 0.128.0. Therefore, it's better to upper-bind FastAPI rather than exclude it, because there might be more versions of FastAPI released before Cadwyn gets fixed. Also the issue zmievsa/cadwyn#316 has been created, describing the root cause and suggested way how the issue could be fixed in Cadwyn and comment on the reason for upper binding was added to make sure we keep track of it.
|
@jscheffl, @gopidesupavan -> I created the issue in Cadwyn zmievsa/cadwyn#316 , describing the issue and updated the exclusion from #59856 with link to the issue and @pierrejeambrun -> I am not exactly sure about the reasoning of mocking the |
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning-up behind my short term fix!
apache#59859) * Improve FastApi exclusion for Cadwyn incompatibility and link Cadwyn issue Cadwyn is not compatible (yet) with FastAPI 0.128.0 - but the changes in FastAPI are deliberately breaking so there is no way we are going to support FastAPI >=0.128.0 unless there is a fix from Cadwyn (and we also need to fix generating models for task-sdk to not use private method that has been removed in FastAPI 0.128.0. Therefore, it's better to upper-bind FastAPI rather than exclude it, because there might be more versions of FastAPI released before Cadwyn gets fixed. Also the issue zmievsa/cadwyn#316 has been created, describing the root cause and suggested way how the issue could be fixed in Cadwyn and comment on the reason for upper binding was added to make sure we keep track of it. * Apply suggestion from @potiuk
|
Thank you @potiuk |
apache#59859) * Improve FastApi exclusion for Cadwyn incompatibility and link Cadwyn issue Cadwyn is not compatible (yet) with FastAPI 0.128.0 - but the changes in FastAPI are deliberately breaking so there is no way we are going to support FastAPI >=0.128.0 unless there is a fix from Cadwyn (and we also need to fix generating models for task-sdk to not use private method that has been removed in FastAPI 0.128.0. Therefore, it's better to upper-bind FastAPI rather than exclude it, because there might be more versions of FastAPI released before Cadwyn gets fixed. Also the issue zmievsa/cadwyn#316 has been created, describing the root cause and suggested way how the issue could be fixed in Cadwyn and comment on the reason for upper binding was added to make sure we keep track of it. * Apply suggestion from @potiuk
apache#59859) * Improve FastApi exclusion for Cadwyn incompatibility and link Cadwyn issue Cadwyn is not compatible (yet) with FastAPI 0.128.0 - but the changes in FastAPI are deliberately breaking so there is no way we are going to support FastAPI >=0.128.0 unless there is a fix from Cadwyn (and we also need to fix generating models for task-sdk to not use private method that has been removed in FastAPI 0.128.0. Therefore, it's better to upper-bind FastAPI rather than exclude it, because there might be more versions of FastAPI released before Cadwyn gets fixed. Also the issue zmievsa/cadwyn#316 has been created, describing the root cause and suggested way how the issue could be fixed in Cadwyn and comment on the reason for upper binding was added to make sure we keep track of it. * Apply suggestion from @potiuk
…issue
Cadwyn is not compatible (yet) with FastAPI 0.128.0 - but the changes in FastAPI are deliberately breaking so there is no way we are going to support FastAPI >=0.128.0 unless there is a fix from Cadwyn (and we also need to fix generating models for task-sdk to not use private method that has been removed in FastAPI 0.128.0.
Therefore, it's better to upper-bind FastAPI rather than exclude it, because there might be more versions of FastAPI released before Cadwyn gets fixed.
Also the issue zmievsa/cadwyn#316 has been created, describing the root cause and suggested way how the issue could be fixed in Cadwyn and comment on the reason for upper binding was added to make sure we keep track of it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.