-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Remove all sensitive export functionality from airflowctl #59850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I will fix the CI test failure in test_variable_command.py. |
5741dfa to
412feaf
Compare
|
No need to backport in my view. |
412feaf to
e257802
Compare
|
Also - it needs a newsfragment describing change in behaviour. |
e257802 to
746003a
Compare
|
You need to remove "export" command from the generation script :). |
746003a to
c333c5c
Compare
Applied! |
c333c5c to
345bf75
Compare
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
345bf75 to
81b6b97
Compare
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the rework and discussions. Looks good to me now!
|
Sorry for joining late, and I may have missed something. The issue was stating connections and variables export, but why |
Yes, your are right. Sorry about that 😵💫 . Should I open an another pr to add it back? |
Yes, let’s open another PR to add it back. Thanks! |
closes: #59841
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.