Skip to content

Conversation

@henry3260
Copy link
Contributor

closes: #59841


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk potiuk changed the title Remove all export functionality from airflowctl Remove all sensitive export functionality from airflowctl Dec 27, 2025
@henry3260
Copy link
Contributor Author

henry3260 commented Dec 27, 2025

I will fix the CI test failure in test_variable_command.py.

@henry3260 henry3260 force-pushed the remove-export-airflowctl branch from 5741dfa to 412feaf Compare December 27, 2025 10:30
@jscheffl jscheffl removed the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Dec 27, 2025
@jscheffl
Copy link
Contributor

No need to backport in my view.

@henry3260 henry3260 force-pushed the remove-export-airflowctl branch from 412feaf to e257802 Compare December 27, 2025 13:25
@potiuk
Copy link
Member

potiuk commented Dec 27, 2025

Also - it needs a newsfragment describing change in behaviour.

@henry3260 henry3260 force-pushed the remove-export-airflowctl branch from e257802 to 746003a Compare December 28, 2025 19:30
@potiuk
Copy link
Member

potiuk commented Dec 28, 2025

You need to remove "export" command from the generation script :).

@henry3260 henry3260 force-pushed the remove-export-airflowctl branch from 746003a to c333c5c Compare December 29, 2025 08:56
@henry3260
Copy link
Contributor Author

You need to remove "export" command from the generation script :).

Applied!

@henry3260 henry3260 force-pushed the remove-export-airflowctl branch from c333c5c to 345bf75 Compare December 29, 2025 18:59
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@henry3260 henry3260 force-pushed the remove-export-airflowctl branch from 345bf75 to 81b6b97 Compare December 30, 2025 17:58
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rework and discussions. Looks good to me now!

@jscheffl jscheffl merged commit 030ae0a into apache:main Dec 30, 2025
126 checks passed
@henry3260 henry3260 deleted the remove-export-airflowctl branch December 31, 2025 01:21
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Jan 2, 2026
stegololz pushed a commit to stegololz/airflow that referenced this pull request Jan 9, 2026
@bugraoz93
Copy link
Contributor

bugraoz93 commented Jan 13, 2026

Sorry for joining late, and I may have missed something. The issue was stating connections and variables export, but why pool export also deleted that I didn't understand. I think we should add this back since pools don't store anything sensitive

@henry3260
Copy link
Contributor Author

Sorry for joining late, and I may have missed something. The issue was stating connections and variables export, but why pool export also deleted that I didn't understand. I think we should add this back since pools don't store anything sensitive

Yes, your are right. Sorry about that 😵‍💫 .

#59850 (comment)

Should I open an another pr to add it back?

@jason810496
Copy link
Member

Should I open an another pr to add it back?

Yes, let’s open another PR to add it back. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove all sensitive export functionality from airflowctl

6 participants