Add E2E tests for backfill pause and stop controls #59738

KyeongJooni · 2025-12-23T05:58:04Z

Add UI E2E tests for backfill pause, resume, and cancel controls

This PR adds end-to-end tests to verify the backfill control functionality on the DAG detail page.

What this tests:

Pausing a running backfill and verifying status changes to paused
Resuming a paused backfill and verifying status returns to running
Cancelling an active backfill and verifying status changes to cancelled
Verifying that cancelled backfills cannot be resumed

Implementation:

Created BackfillPage page object following existing POM pattern
Added test suite backfill-controls.spec.ts with 3 test cases
All tests follow the same structure as existing E2E tests (dags-list.spec.ts)

closes: #59594

While syncing/rebasing with upstream main on the previous PR, the diff unintentionally included files I didn’t intend to modify, which in turn triggered CODEOWNERS review requests broadly. To reduce noise and reviewer burden, I closed the original PR and opened this one with a cleaned-up, focused set of changes.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

choo121600 · 2025-12-23T07:33:51Z

Thanks for PR :)
As I mentioned in the previous PR(#59705), It seems that the tests are failing.
Could you let me know if the tests passed when you ran them locally.

KyeongJooni · 2025-12-23T15:30:49Z

Thanks for the review! I've updated the locators to scope them within the dialog context.

I attempted to run the tests locally to verify the changes. The dialog scoping follows the same pattern used in DagsPage and ensures locators only match elements within the trigger dialog, preventing the strict mode violations.

The key changes:

All form elements (backfillRadio, fromDateInput, toDateInput, runButton) are now scoped to dialog.locator() instead of page.locator()
This prevents conflicts with any duplicate elements that might exist elsewhere on the page

Let me know if you'd like me to make any additional changes!

choo121600 · 2025-12-24T17:52:08Z

On my side, the tests seem to be failing.
Could you confirm whether they passed locally?
If you could also share the logs, it would be helpful for us to debug this together😉

vatsrahul1001 · 2025-12-28T13:00:03Z

@KyeongJooni can we look at failure tests?

vatsrahul1001 · 2026-01-05T09:57:25Z

@KyeongJooni you need a rebase

KyeongJooni · 2026-01-05T13:13:07Z

@KyeongJooni you need a rebase

@vatsrahul1001 Rebased on latest main as requested.

I've attempted to fix the test failures:

Replaced waitForPageLoad() with page.waitForLoadState()
Added status verification using getBackfillStatus()
Updated to align with upstream API changes

Could you please check if the tests pass now? Let me know if there are any remaining issues.

airflow-core/src/airflow/ui/tests/e2e/specs/backfill-controls.spec.ts

airflow-core/src/airflow/ui/tests/e2e/pages/BackfillPage.ts

airflow-core/src/airflow/ui/tests/e2e/specs/backfill.spec.ts

airflow-core/src/airflow/ui/tests/e2e/pages/BackfillPage.ts

Rebased on upstream/main to resolve conflicts and fix test failures. - fix: use page.waitForLoadState() instead of waitForPageLoad() - feat: add status verification with getBackfillStatus() - refactor: update to new createBackfill(dagName, options) API - refactor: apply global auth pattern from PR apache#59692 - refactor: use dynamic dates instead of hardcoded values Closes apache#59594

Avoid waitForNoActiveBackfill() timeout by testing controls on actively running backfills instead of waiting for completion. Add AUTH_FILE import and align with backfill.spec.ts patterns.

- Use beforeEach/afterEach pattern with serial mode - Replace waitForTimeout with explicit state waits - Remove unused helper methods - Update test structure and naming conventions

Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>

airflow-core/src/airflow/ui/tests/e2e/pages/BackfillPage.ts

choo121600 · 2026-01-14T12:54:01Z

It looks like a test for "cancelled backfill cannot be resumed" might be missing.

airflow-core/src/airflow/ui/tests/e2e/specs/backfill.spec.ts

…in E2E tests

Co-authored-by: Yeonguk Choo <choo121600@gmail.com>

vatsrahul1001 · 2026-01-15T06:08:03Z

@KyeongJooni Thanks for the fixes. I see tests are passing now, they all have retries and are flaky. Could you investigate it

KyeongJooni · 2026-01-16T02:04:55Z

@KyeongJooni Thanks for the fixes. I see tests are passing now, they all have retries and are flaky. Could you investigate it

Investigated and fixed in d02b5eb. The issue was .catch(() => undefined) on waitForResponse - when the response wasn't caught, the test proceeded without waiting for the API to complete. Removed the catch and increased timeout. Hopefully the tests will be stable now.

choo121600 · 2026-01-21T05:54:18Z

@KyeongJooni it would be helpful if you could verify that all tests pass locally without flakiness, mark the resolved comments as resolved, and provide a brief summary of the changes.
Feel free to mention me when the next round of review is needed 😉

KyeongJooni · 2026-01-21T07:27:15Z

@KyeongJooni it would be helpful if you could verify that all tests pass locally without flakiness, mark the resolved comments as resolved, and provide a brief summary of the changes. Feel free to mention me when the next round of review is needed 😉

@choo121600

Summary of Changes

Extended backfill date range (1 day → 60 days) to ensure backfill runs long enough for pause/cancel tests
Added retry logic in beforeEach using expect().toPass() to handle race conditions
Added waitForBackdropClosed() to fix Chakra UI dialog timing issues
Added 409 conflict handling in createBackfill() for retry on conflict

All resolved comments have been marked. I expect the tests to pass with these changes, but let me know if any issues remain.

choo121600

Cool, Looks good!
All tests are passing, and this part looks fine to me.
Thanks for the hard work 🙂

vatsrahul1001 · 2026-01-23T11:07:43Z

@KyeongJooni, Great work. One last thing, I see tests are passing, but on retry, can you check why there is flakiness?

KyeongJooni · 2026-01-23T12:42:17Z

@KyeongJooni, Great work. One last thing, I see tests are passing, but on retry, can you check why there is flakiness?

@vatsrahul1001 The flakiness in backfill tests has been resolved. The only flaky test in the latest CI run is xcoms.spec.ts, which is unrelated to this PR. All backfill tests pass without retry on all browsers (Chromium, Firefox, WebKit).

vatsrahul1001 · 2026-01-26T09:52:44Z

Great work @KyeongJooni !

boring-cyborg · 2026-01-26T09:53:30Z

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

choo121600 · 2026-01-26T11:00:31Z

Awesome, @KyeongJooni congrats on your first merge 🎉
Thanks for the contribution!

Add E2E tests for backfill pause and stop controls Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com> Co-authored-by: Yeonguk Choo <choo121600@gmail.com>

KyeongJooni requested a review from vatsrahul1001 as a code owner December 23, 2025 05:58

boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Dec 23, 2025

KyeongJooni changed the title ~~Feat: add E2E tests for backfill pause and stop controls~~ Add E2E tests for backfill pause and stop controls Dec 23, 2025

KyeongJooni force-pushed the e2e/backfill-controls branch from b76840f to 84981dc Compare January 5, 2026 13:10

KyeongJooni force-pushed the e2e/backfill-controls branch from 7ee4110 to ddf22b0 Compare January 6, 2026 05:51

vatsrahul1001 reviewed Jan 6, 2026

View reviewed changes

KyeongJooni force-pushed the e2e/backfill-controls branch 4 times, most recently from 054eb92 to ef55450 Compare January 7, 2026 13:49

KyeongJooni requested a review from choo121600 as a code owner January 9, 2026 01:25

choo121600 reviewed Jan 9, 2026

View reviewed changes

airflow-core/src/airflow/ui/tests/e2e/pages/BackfillPage.ts Outdated Show resolved Hide resolved

vatsrahul1001 reviewed Jan 9, 2026

View reviewed changes

airflow-core/src/airflow/ui/tests/e2e/specs/backfill.spec.ts Show resolved Hide resolved

airflow-core/src/airflow/ui/tests/e2e/specs/backfill.spec.ts Show resolved Hide resolved

airflow-core/src/airflow/ui/tests/e2e/pages/BackfillPage.ts Outdated Show resolved Hide resolved

KyeongJooni and others added 9 commits January 10, 2026 23:18

fix(ui): test backfill controls on running backfills

ea10492

Avoid waitForNoActiveBackfill() timeout by testing controls on actively running backfills instead of waiting for completion. Add AUTH_FILE import and align with backfill.spec.ts patterns.

refactor(ui): restructure backfill controls tests per review feedback

3aec173

- Use beforeEach/afterEach pattern with serial mode - Replace waitForTimeout with explicit state waits - Remove unused helper methods - Update test structure and naming conventions

test(ui): use exact aria-label selectors for backfill controls

5c994c2

fix(ui): wait for aria-label change after pause button click

951e387

fix(ui): cancel existing backfill before creating new one in beforeEach

eff144c

Update airflow-core/src/airflow/ui/tests/e2e/specs/backfill.spec.ts

3c0f685

Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>

Update airflow-core/src/airflow/ui/tests/e2e/specs/backfill.spec.ts

2a250e5

Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>

refactor(ui): remove unused backfillBanner locator

d9d2899

KyeongJooni force-pushed the e2e/backfill-controls branch from 2c55999 to d9d2899 Compare January 10, 2026 14:20

Merge branch 'main' into e2e/backfill-controls

852bd6b

choo121600 reviewed Jan 14, 2026

View reviewed changes

airflow-core/src/airflow/ui/tests/e2e/pages/BackfillPage.ts Outdated Show resolved Hide resolved

choo121600 reviewed Jan 14, 2026

View reviewed changes

airflow-core/src/airflow/ui/tests/e2e/specs/backfill.spec.ts Outdated Show resolved Hide resolved

KyeongJooni and others added 5 commits January 14, 2026 22:15

fix(ui): replace waitForLoadState with element visibility assertions …

b2d73be

…in E2E tests

Update airflow-core/src/airflow/ui/tests/e2e/specs/backfill.spec.ts

59a5f01

Co-authored-by: Yeonguk Choo <choo121600@gmail.com>

test(ui): add E2E test for cancelled backfill cannot be resumed

8c9ce2b

fix(ui): wait for API response before checking modal close in E2E tests

653ee55

fix(ui): exclude dry_run and check success status in createBackfill E2E

de8267e

fix(ui): remove catch and increase timeout in createBackfill E2E

d02b5eb

KyeongJooni and others added 7 commits January 17, 2026 13:29

fix(ui): improve error handling in createBackfill E2E test

009c038

fix(ui): handle 409 conflict in createBackfill E2E by retrying

5644ed1

fix(ui): wait for backdrop to disappear before clicking cancel button

74d8caf

Merge branch 'main' into e2e/backfill-controls

0a45f20

fix: force close modal if not closed after successful API response

62679d7

fix(ui): improve backfill e2e test stability

b966a9f

fix(ui): extend backfill date range and add retry logic for pauseButton

a83cb5a

choo121600 approved these changes Jan 22, 2026

View reviewed changes

vatsrahul1001 approved these changes Jan 26, 2026

View reviewed changes

vatsrahul1001 merged commit 4e8274c into apache:main Jan 26, 2026
77 checks passed

Add E2E tests for backfill pause and stop controls #59738

Add E2E tests for backfill pause and stop controls #59738

Conversation

KyeongJooni commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

choo121600 commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KyeongJooni commented Dec 23, 2025

Uh oh!

choo121600 commented Dec 24, 2025

Uh oh!

vatsrahul1001 commented Dec 28, 2025

Uh oh!

vatsrahul1001 commented Jan 5, 2026

Uh oh!

KyeongJooni commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

choo121600 commented Jan 14, 2026

Uh oh!

Uh oh!

vatsrahul1001 commented Jan 15, 2026

Uh oh!

KyeongJooni commented Jan 16, 2026

Uh oh!

choo121600 commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KyeongJooni commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

choo121600 left a comment

Choose a reason for hiding this comment

Uh oh!

vatsrahul1001 commented Jan 23, 2026

Uh oh!

KyeongJooni commented Jan 23, 2026

Uh oh!

vatsrahul1001 commented Jan 26, 2026

Uh oh!

Uh oh!

boring-cyborg bot commented Jan 26, 2026

Uh oh!

choo121600 commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

KyeongJooni commented Dec 23, 2025 •

edited

Loading

choo121600 commented Dec 23, 2025 •

edited

Loading

KyeongJooni commented Jan 5, 2026 •

edited

Loading

choo121600 commented Jan 21, 2026 •

edited

Loading

KyeongJooni commented Jan 21, 2026 •

edited

Loading