Skip to content

Refactor SQLA2 ui/test_assets.py #59486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
steveahnahn wants to merge 1 commit into from
Closed

Refactor SQLA2 ui/test_assets.py #59486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,7 @@ repos:
^airflow-ctl.*\.py$|
^airflow-core/src/airflow/models/.*\.py$|
^airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_assets.py$|
^airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_assets.py$|
^providers/openlineage/.*\.py$|
^task_sdk.*\.py$
pass_filenames: true
Expand Down
7 changes: 5 additions & 2 deletions airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import pendulum
import pytest
from sqlalchemy import select

from airflow.models.asset import AssetDagRunQueue, AssetEvent, AssetModel
from airflow.providers.standard.operators.empty import EmptyOperator
Expand Down Expand Up @@ -95,7 +96,9 @@ def test_should_set_last_update_only_for_queued_and_hide_flag(self, test_client,

assets = {
a.uri: a
for a in session.query(AssetModel).filter(AssetModel.uri.in_(["s3://bucket/A", "s3://bucket/B"]))
for a in session.scalars(
select(AssetModel).where(AssetModel.uri.in_(["s3://bucket/A", "s3://bucket/B"]))
).all()
}
# Queue and add an event only for A
session.add(AssetDagRunQueue(asset_id=assets["s3://bucket/A"].id, target_dag_id="two_assets_equal"))
Expand Down Expand Up @@ -145,7 +148,7 @@ def test_last_update_respects_latest_run_filter(self, test_client, dag_maker, se
dr = dag_maker.create_dagrun()
dag_maker.sync_dagbag_to_db()

asset = session.query(AssetModel).filter(AssetModel.uri == "s3://bucket/F").one()
asset = session.scalars(select(AssetModel).where(AssetModel.uri == "s3://bucket/F")).one()
session.add(AssetDagRunQueue(asset_id=asset.id, target_dag_id="filter_run"))
# event before latest_run should be ignored
ts_base = dr.logical_date or pendulum.now()
Expand Down
Loading