Skip to content

Remove Legacy Query Object Usage from test_variables.py #59428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
henry3260 wants to merge 2 commits into from
Closed

Remove Legacy Query Object Usage from test_variables.py #59428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d2616c
Remove Legacy Query Object Usage from test_variables.py
henry3260 Dec 15, 2025
80d46aa
Merge branch 'main' into fix-test_variables
henry3260 Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,7 @@ repos:
^airflow-ctl.*\.py$|
^airflow-core/src/airflow/models/.*\.py$|
^airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_assets.py$|
^airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_variables.py$|
^task_sdk.*\.py$
pass_filenames: true
- id: update-supported-versions
Expand Down
7 changes: 4 additions & 3 deletions airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_variables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
from unittest.mock import ANY

import pytest
from sqlalchemy import select

from airflow.models.team import Team
from airflow.models.variable import Variable
Expand Down Expand Up @@ -65,7 +66,7 @@ def create_file_upload(content: dict) -> BytesIO:

@provide_session
def _create_variables(session) -> None:
team = session.query(Team).where(Team.name == "test").one()
team = session.scalars(select(Team).where(Team.name == "test")).one()

Variable.set(
key=TEST_VARIABLE_KEY,
Expand Down Expand Up @@ -130,13 +131,13 @@ def create_variables(self):
class TestDeleteVariable(TestVariableEndpoint):
def test_delete_should_respond_204(self, test_client, session):
self.create_variables()
variables = session.query(Variable).all()
variables = session.scalars(select(Variable)).all()
assert len(variables) == 5
response = test_client.delete(f"/variables/{TEST_VARIABLE_KEY}")
assert response.status_code == 204
response = test_client.delete(f"/variables/{TEST_VARIABLE_KEY4}")
assert response.status_code == 204
variables = session.query(Variable).all()
variables = session.scalars(select(Variable)).all()
assert len(variables) == 3
check_last_log(session, dag_id=None, event="delete_variable", logical_date=None)

Expand Down
Loading