-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix misleading error message when GitHook creation fails #59084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
approved these changes
Dec 5, 2025
ac325a8 to
14559b6
Compare
pierrejeambrun
approved these changes
Dec 8, 2025
Contributor
Author
|
Sorry for the spam folks, possibly due to a bad rebase I had! |
Contributor
Author
|
Ahhh missed the v3 label! |
Contributor
Author
|
Oh this one will need manual port over. |
Contributor
Author
|
Manual port to v3 branch here: #59236 |
52 tasks
henry3260
pushed a commit
to henry3260/airflow
that referenced
this pull request
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when GitHook creation failed (take for example a simple case of git connection not found), the exception was caught and suppressed, allowing bundle initialization to proceed in a way, which was a facade. This led to a misleading error message later:
"Connection {conn_id} doesn't have a host url"instead of the actual error.I am making this change to ensure that exceptions propagate immediately during bundle creation with clear error messages. The DAG processor handles exceptions per-bundle, so one failing bundle doesn't prevent others from loading successfully.
For testing, use a config like this where git connection doesnt exist:
Before it looked like this:
Now it looks like this:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.