Skip to content

Version cap fastapi due to is_coroutine changes in 0.123.5#58980

Merged
potiuk merged 4 commits intoapache:mainfrom
bugraoz93:version-cap-fastapi
Dec 2, 2025
Merged

Version cap fastapi due to is_coroutine changes in 0.123.5#58980
potiuk merged 4 commits intoapache:mainfrom
bugraoz93:version-cap-fastapi

Conversation

@bugraoz93
Copy link
Contributor

@bugraoz93 bugraoz93 commented Dec 2, 2025

Fixes CI failures in https://github.com/apache/airflow/actions/runs/19874997189/job/56960727172


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for it to succeed.

@potiuk potiuk added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Dec 2, 2025
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@potiuk
Copy link
Member

potiuk commented Dec 2, 2025

hmmm. strange but it does not seem to be it

@bugraoz93
Copy link
Contributor Author

Indeed this is not it 🤔

@bugraoz93 bugraoz93 changed the title Version cap fastapi due to is_coroutine changes in 1.125.0 Version cap fastapi due to is_coroutine changes in 0.125.0 Dec 2, 2025
@bugraoz93
Copy link
Contributor Author

bugraoz93 commented Dec 2, 2025

My bad! Thanks Jarek! :(

@potiuk
Copy link
Member

potiuk commented Dec 2, 2025

Actually .... that was even more wrong :) 0.123.5 not 1.125.0 😱

@bugraoz93
Copy link
Contributor Author

Actually .... that was even more wrong :) 0.123.5 not 1.125.0 😱

how I ended up making this numbers 😱

@bugraoz93 bugraoz93 changed the title Version cap fastapi due to is_coroutine changes in 0.125.0 Version cap fastapi due to is_coroutine changes in 0.123.5 Dec 2, 2025
@potiuk potiuk mentioned this pull request Dec 2, 2025
1 task
@potiuk potiuk merged commit fe99a32 into apache:main Dec 2, 2025
87 checks passed
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker fe99a32 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

@potiuk
Copy link
Member

potiuk commented Dec 2, 2025

Merged - as it seems to work now. Unfortunately the way how Fast API issues are designed - we do not have a way to create an issue there so I think someonw with more fastapi knowledge will have to investigate if that's our issue or FastaPI.

cc: @pierrejeambrun @ephraimbuddy -> this one will likely break 3.1.4 release, so you might also need to cherry-pick that one (unless there is a comment from FastAPI team.

I am mostly not available tomorrow to pick that one up.

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just about time when we were going to release haha!

@uranusjr
Copy link
Member

uranusjr commented Dec 3, 2025

What’s the error before this change? I can probably look into the root cause.

@amoghrajesh
Copy link
Contributor

@ephraimbuddy
Copy link
Contributor

Airflow 3.1 is not affected. it has fastapi version limit of 118

@potiuk
Copy link
Member

potiuk commented Dec 3, 2025

Cool !

@potiuk
Copy link
Member

potiuk commented Dec 3, 2025

@tirkarthi investigated and looks like cadwyn badly wrapping our sync calls - see zmievsa/cadwyn#309

@bugraoz93
Copy link
Contributor Author

Great to hear the release hasn't been impacted! Thanks @tirkarthi for following up! Hopefully, it will be fixed for the next wave 🤞

itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
)

* Version cap fastapi due to is_coroutine changes in 1.125.0

* Update airflow-core/pyproject.toml

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>

* Apply suggestion from @potiuk

* Apply suggestion from @potiuk

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants