Version cap fastapi due to is_coroutine changes in 0.123.5#58980
Version cap fastapi due to is_coroutine changes in 0.123.5#58980potiuk merged 4 commits intoapache:mainfrom
Conversation
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
|
hmmm. strange but it does not seem to be it |
|
Indeed this is not it 🤔 |
|
My bad! Thanks Jarek! :( |
|
Actually .... that was even more wrong :) 0.123.5 not 1.125.0 😱 |
how I ended up making this numbers 😱 |
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker fe99a32 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
|
Merged - as it seems to work now. Unfortunately the way how Fast API issues are designed - we do not have a way to create an issue there so I think someonw with more fastapi knowledge will have to investigate if that's our issue or FastaPI. cc: @pierrejeambrun @ephraimbuddy -> this one will likely break 3.1.4 release, so you might also need to cherry-pick that one (unless there is a comment from FastAPI team. I am mostly not available tomorrow to pick that one up. |
amoghrajesh
left a comment
There was a problem hiding this comment.
Nice! Just about time when we were going to release haha!
|
What’s the error before this change? I can probably look into the root cause. |
|
@uranusjr here's an example run that failed: https://github.com/apache/airflow/actions/runs/19874997189/job/56960727172 |
|
Airflow 3.1 is not affected. it has fastapi version limit of 118 |
|
Cool ! |
|
@tirkarthi investigated and looks like cadwyn badly wrapping our sync calls - see zmievsa/cadwyn#309 |
|
Great to hear the release hasn't been impacted! Thanks @tirkarthi for following up! Hopefully, it will be fixed for the next wave 🤞 |
Fixes CI failures in https://github.com/apache/airflow/actions/runs/19874997189/job/56960727172
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.