-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Remove global from celery provider #58869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove global from celery provider #58869
Conversation
providers/celery/src/airflow/providers/celery/executors/celery_executor_utils.py
Show resolved
Hide resolved
7d647ea to
9a1f29d
Compare
9a1f29d to
e326e6d
Compare
* Remove global from celery provider * Remove global from celery provider, add caching
* Remove global from celery provider * Remove global from celery provider, add caching
|
We're pretty sure that we traced worker processes getting We upgraded Airflow 3.1.1 → 3.1.6 and while doing so went By downgrading UPDATE: Looks like we got confused during debugging and it was actually the change 3.13.1 → 3.14.0 from #58591. |
@michaelosthege hypothesis ... if not duplicate hostname could it be that the duplicate hostname check sometimes needs longer running into timeout as well? Not sure about a specific error message... |
No idea how long that code takes to execute, but we had tried increasing How does the UP message travel to the parent? Via the message broker? We also observed a "clocks out of sync" warning in the logs, but with the worker and Redis containers running on the same host that doesn't make any sense. |
Another small increment to remove global statements for PR #58116
This removes global statement in celery, a classsic thing where
functools.cache()can help. Also centralization of config retrieval in this case makes code better in general.globalis evil.