-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Extend airflow_ti_running metrics by scheduled, queued and deferred #58819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend airflow_ti_running metrics by scheduled, queued and deferred #58819
Conversation
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this all makes sense. But the configuration can not be "just" renamed as well as some mypy static fails. I assume you know how to fix.
b09efdf to
928210a
Compare
5f73cee to
62d61ac
Compare
62d61ac to
877752b
Compare
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me, some other pair of eyes might be good, otherwise LGTM. Will elave it open for a moment for others to review prior merge.
…pache#58819) * ti metric export of scheduled, queued and deferred * Added deprecated warning for new option * only add task_id to metric --------- Co-authored-by: AutomationDev85 <AutomationDev85>
Overview
While working with deferred tasks, we found that the airflow_ti_running metric does not include task instances in the deferred state. This change extends metric export to also cover scheduled, queued, and deferred states. With these metrics you can build dashboards that show per-DAG load in running and deferred states, and monitor how many tasks per DAG are waiting for resources in scheduled and queued states.
Change Summary
Add ti.scheduled, ti.queued and ti.deferred metrics to the code which exports the ti.running
Update description with new metrics.
Add fix for task_id to replace . because task group tasks are breaking the stasd exporting because of using . separator.
Add ti.scheduled, ti.queued and ti.deferred metrics alongside ti.running.
Update metric descriptions to reflect the new states.
Replace . with __ in task_id for StatsD compatibility (task groups use . as a separator, which breaks StatsD’s dot-delimited metric hierarchy).